Add instance-local.yaml support in backend. (#225) #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etting on a development install.
* Rating * changelog * recheck imports * update * add comments to customized components * add comments * fix * add other engagement icons * fix * comment out calling apis and fix tests failing * fix lint * fix lint and rename component * rename stylesheet * comment out things which would not work without proper data * fix lint * fix: add aria-label to button * fix * initial commit * backend for likes and comment * Install plone.app.discussion * 90% done * minor fix * fix after review * backend german translation * add cypress test * update pnpm * add backend changelog * add upgreade steps and update backend test * minor fix * add enable_likes behaviour and polish code * polish css code * fix test and format * final polish code * Add upgrade step to install plone.app.discussion * refactor code based on review * fix cypress test * fix backend-test * fix format * fix format * fix ci and cypress test * fix the text of sharing content * minor typo * add docs and improve global settings for like * add documentation and changelog * rename changelog file * Fix the bug when navigating to different pages and saving pages * Hide enable_likes field if enable_content_rating registry setting is disabled * final fix * There's no reason to reindex votes, since there is no votes index * Rename docs page to Content Interactions * Use proper i18n mechanism for translating share email subject * Edit changelog * Enable content rating for new sites, disable for upgraded sites * Fix cypress test, ratings are enabled by default now --------- Co-authored-by: iFlameing <[email protected]> Co-authored-by: David Glick <[email protected]>
* Update to Volto 19.29.0 and vlt 7.5.1 * lock
fredvd
changed the title
sneridagh
approved these changes
Nov 14, 2025
davisagli
requested changes
Jan 5, 2026
Member
davisagli
left a comment
davisagli
left a comment
There was a problem hiding this comment.
Sorry for the long delay. I'm ok with the basic idea here, but currently it breaks if there is no instance-local.yml (as you can see in the failing tests).
| @grep -E '^[a-zA-Z_-]+:.*?## .*$$' $(MAKEFILE_LIST) | sort | awk 'BEGIN {FS = ":.*?## "}; {printf "\033[36m%-30s\033[0m %s\n", $$1, $$2}' | ||
|
|
||
| instance/etc/zope.ini instance/etc/zope.conf: ## Create instance configuration | ||
| instance/etc/zope.ini instance/etc/zope.conf: instance.yaml instance-local.yaml ## Create instance configuration |
Member
There was a problem hiding this comment.
Listing instance-local.yml here makes it break with No rule to make target 'instance-local.yaml', needed by 'instance/etc/zope.ini'. if the file does not exist. Since it's optional, I would just remove it from this line. (Though, that means this target will not run again if instance-local.yml is the only file that changed.)
Suggested change
| instance/etc/zope.ini instance/etc/zope.conf: instance.yaml instance-local.yaml ## Create instance configuration | |
| instance/etc/zope.ini instance/etc/zope.conf: instance.yaml ## Create instance configuration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.