Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring #1

Merged
merged 7 commits into from
Oct 4, 2024
Merged

Refactoring #1

merged 7 commits into from
Oct 4, 2024

Conversation

jnptk
Copy link
Member

@jnptk jnptk commented Oct 2, 2024

ToDo:

  • fix inner block z-index
  • fix inner block sidebar selection

jnptk and others added 3 commits October 2, 2024 10:01
- clicking on toggle does the toggle but also bubbles to select the block
- clicking on title does not toggle but also bubbles to select the block
This is especially important for dragging in edit mode when there is a gray background that we don't want to obstruct, but also in general if the accordion is styled with a background in a customization.
@reekitconcept
Copy link
Member

I've fixed the first problem (z-index vs. click event propagation), but the sidebar problem is still tbd.

@reekitconcept
Copy link
Member

According to my testing, the sidebar also works well with inner block selection.

It does not select the text block, but even outside if there is a text block and you click on it, it does not go to the “Block” tab, it goes to the “Page” tab. It is consistent with inside the accordion.

But. if I add an image block inside the accordion, and I click to it then it does select it in the sidebar and does switch to the Block tab. So this is good.

I think that the text block selection behavior wrt the sidebar is either correct, or if not then it’s a generic problem of the text block, not related to the current ticket.

@sneridagh sneridagh marked this pull request as ready for review October 4, 2024 10:19
@sneridagh sneridagh merged commit 9fb3406 into main Oct 4, 2024
6 checks passed
@sneridagh sneridagh deleted the refactoring branch October 4, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants