Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error when we are deleting the accordion block in edit mode. #3

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Fix error when we are deleting the accordion block in edit mode. #3

merged 1 commit into from
Nov 5, 2024

Conversation

iFlameing
Copy link
Member

In useeffect we can only return the function. Not a javascript code.

@iFlameing iFlameing changed the base branch from main to fhnw November 4, 2024 11:14
reekitconcept
reekitconcept approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@reekitconcept reekitconcept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By code review I can approve that this is a correct and necessary fix.

@reekitconcept reekitconcept merged commit 25cf02d into fhnw Nov 5, 2024
4 of 6 checks passed
@reekitconcept reekitconcept deleted the accordion-delete branch November 5, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reekitconcept reekitconcept reekitconcept approved these changes

@jnptk jnptk Awaiting requested review from jnptk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iFlameing @reekitconcept