Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a11y tests infrastructure #300

Merged
merged 18 commits into from
Dec 28, 2023
Merged

Add a11y tests infrastructure #300

merged 18 commits into from
Dec 28, 2023

Conversation

sneridagh
Copy link
Member

No description provided.

@sneridagh sneridagh mentioned this pull request Dec 15, 2023
Closed
@sneridagh sneridagh linked an issue Dec 19, 2023 that may be closed by this pull request
Add Accessibility tests and fix violations #301
Closed
@iRohitSingh
Copy link
Member

iRohitSingh commented Dec 21, 2023 •
edited
Loading

@sneridagh I Add A11y test and fix violation, the only thing is missing

  1. Home page a11y test ( once this pr Upgrade and adapt the theme tovolto-slider-block 6.0.0 add-on #288 merge the slider block a11y test is also fixed )
  2. Accordion block a11y test (Error is thrown but it is totally unrelated. Not able to find the culprit.)
  3. Same for table block. Both are giving exact error.

Screenshot of 'Error in Accordion block and table block'

Screenshot 2023-12-21 at 9 44 59 PM

@sneridagh
Copy link
Member Author

@sneridagh I Add A11y test and fix violation, the only thing is missing

  1. Home page a11y test ( once this pr Adapt new slider (6.0.0) in light theme #288 merge the slider block a11y test is also fixed )
  2. Accordion block a11y test (Error is thrown but it is totally unrelated. Not able to find the culprit.)
  3. Same for table block. Both are giving exact error.

Screenshot of 'Error in Accordion block and table block'

Ok, I will merge the slider PR. The error in the screenshot is related to the slider, not the accordion, right? I can see the classnames of it.

@iRohitSingh
Copy link
Member

iRohitSingh commented Dec 22, 2023 •
edited
Loading

@sneridagh I Add A11y test and fix violation, the only thing is missing

  1. Home page a11y test ( once this pr Adapt new slider (6.0.0) in light theme #288 merge the slider block a11y test is also fixed )
  2. Accordion block a11y test (Error is thrown but it is totally unrelated. Not able to find the culprit.)
  3. Same for table block. Both are giving exact error.

Screenshot of 'Error in Accordion block and table block'

Ok, I will merge the slider PR. The error in the screenshot is related to the slider, not the accordion, right? I can see the classnames of it.

Yeah, I also think the same thing. I don't know from where it is leaking in Accordion and table block. I am unable to find the culprit that's why I mentioned it. After the slider pr merge I will try once again.

@sneridagh
Copy link
Member Author

I just merged andd sync this branch.

@iRohitSingh
Copy link
Member

@sneridagh I don't know how to fix this a11y error. sometimes it passes, sometimess it doesn't.

'Ensure that the page, or at least one of its frames contains a level-on headeing'

and also please deploy the new image of kitconceptvoltolighttheme. my changes are not available in docker image so maps block a11y is falling.

On ci text block passes but locally it fails screenshot

Screenshot 2023-12-27 at 9 32 58 PM

@sneridagh sneridagh merged commit 9a55a83 into main Dec 28, 2023
9 checks passed
@sneridagh sneridagh deleted the acceptancea11ytests branch December 28, 2023 14:30
sneridagh added a commit that referenced this pull request Jan 2, 2024
@sneridagh
Merge branch 'main' into customstylewrapper
2397492 
* main:
  Updated the Language Selector (#321)
  Add a11y tests infrastructure (#300)
sneridagh added a commit that referenced this pull request Jan 2, 2024
@sneridagh
Merge branch 'main' into customstylewrapperandimprovedgroupingwithCus…
0bf4f23 
…tomCSSProps

* main:
  Release 3.0.0-alpha.1
  Some style fixes. Added support for new StyleWrapper custom CSS props in Listing and Image blocks (#322)
  Updated the Language Selector (#321)
  Add a11y tests infrastructure (#300)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Accessibility tests and fix violations
2 participants
@sneridagh @iRohitSingh