Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listing variations with summary component #462

Merged
merged 12 commits into from
Feb 11, 2025
Merged

Conversation

davisagli
Copy link
Member

@davisagli davisagli commented Jan 30, 2025

What's included here:

  • Re-label the built-in listing variations to List (was Default), List with images (was Summary), and Grid.
  • Add a new Summary component which is looked up by content type and renders the kicker, title, and description
  • CSS tweaks to make the kicker look correct where it was not shown before
  • Add Summary component implementations for News Item, Event, and File
  • Adjust date rendering in EventView, NewsItemView, and EventMetadata block for better consistency
  • Docs

@davisagli davisagli marked this pull request as ready for review February 10, 2025 00:09
@davisagli davisagli changed the title WIP: Listing variations by content type Listing variations by content type Feb 10, 2025
@davisagli davisagli changed the title Listing variations by content type Listing variations with summary component Feb 10, 2025
Copy link
Member

@sneridagh sneridagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but look at the comments, specially for the introduction of date-fns. Let's talk about it.

packages/volto-light-theme/src/helpers/dates.js Outdated Show resolved Hide resolved
docs/summary.md Show resolved Hide resolved
export default BlogPostSummary;
```

The custom summary component must be registered in the Volto registry in your add-on's `applyConfig` function.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the things that I discussed with @stevepiercy several times is to standardize glossary and concepts. We haven't settled yet on one, but I'd call this "default configuration loader" and try to be consistent everywhere.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sneridagh I'm happy to update it once there's a glossary entry I can link to.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevepiercy how could we do it? More than words, are even concepts... like in this case. "Every time we refer to the applyConfig / add-on's default exported function, etc we say instead: default configuration loader"

@davisagli davisagli requested a review from sneridagh February 10, 2025 20:26
@davisagli davisagli merged commit fb8a140 into main Feb 11, 2025
26 checks passed
@davisagli davisagli deleted the listing-variations branch February 11, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants