-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Listing variations with summary component #462
Conversation
packages/volto-light-theme/src/components/Blocks/Listing/DefaultTemplate.jsx
Show resolved
Hide resolved
packages/volto-light-theme/src/components/Summary/NewsItemSummary.jsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but look at the comments, specially for the introduction of date-fns
. Let's talk about it.
export default BlogPostSummary; | ||
``` | ||
|
||
The custom summary component must be registered in the Volto registry in your add-on's `applyConfig` function. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of the things that I discussed with @stevepiercy several times is to standardize glossary and concepts. We haven't settled yet on one, but I'd call this "default configuration loader" and try to be consistent everywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sneridagh I'm happy to update it once there's a glossary entry I can link to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stevepiercy how could we do it? More than words, are even concepts... like in this case. "Every time we refer to the applyConfig
/ add-on's default exported function, etc we say instead: default configuration loader"
What's included here: