-
Notifications
You must be signed in to change notification settings - Fork 11
CDK-886: Add instructions for replacing kite-dataset in /usr/bin #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Install-Kite.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to use the jar file extension, this is usually called kite-dataset. Also, this is {{site.dataset-command}} above, should that be used here as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced all occurrences with {{site.dataset-command}}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 15 - Some versions of the Cloudera QuickStart VM [come] with Kite installed. Changing this to "Some versions of CDH come with Kite installed."
Install-Kite.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should start a new section so readers have an obvious choice between installing or replacing an existing command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, okay. The reason I hesitate to do that is that I'm pretty sure everyone will always need to do something in order to use the latest version of the software. I'll add the heading "Verifying the Version In Use," which will hopefully get them to keep reading.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should include the version that will be installed so that the "current" link makes a bit more sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason for these revisions is that the version of kite-dataset shipped with CDH is almost always going to be an older version of the kite-dataset command than one you install. These are the instructions for installing and verifying that the latest version is in use.
I discovered this issue when I ran kite-dataset from the ~/ directory, with a new kite-dataset JAR in the ~/ directory, but when I invoked commands, they ran from an old version of the command from /usr/lib/kite/bin/ .
I added the "current" link up here in response to an earlier comment.
I'm don't refer to any specific version, because that would have to be updated with each release.
Instructions for replacing the installed version of kite-dataset with the latest version.