Skip to content

Conversation

@DennisDawson
Copy link

No description provided.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean "create a Session record as an Avro Specific object"? How is that distinct from "create a Session record"?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code commentary reflects the terminology and activity in the code. These serve as "anchors" that readers can latch onto as they try to parse the examples. People new to the Avro object model are not as familiar with what's happening, so it doesn't hurt to give them footholds.

@rdblue
Copy link
Contributor

rdblue commented Mar 13, 2015

This is looking close to being ready. I just had a few comments.

I don't think it makes much sense to add a kite-tutorials level within kite-examples. Could this be a separate repository? It could be in the top level, but there are existing examples already there that may be distracting.

@rdblue
Copy link
Contributor

rdblue commented Mar 23, 2015

I want to have a place for the tutorial code separate from the current examples (even if it's a subdirectory of the current examples). As you say, adding this at the top level could be confusing. Whatever structure you want to use is fine with me, so long as I can start pointing to an unambiguous location for tutorial code.

I don't mind either way. The other PR, event generation, should be moved there as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants