Skip to content

KITE-1155 Deleting an already deleted empty path should not fail the job #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

KITE-1155 Deleting an already deleted empty path should not fail the job #471

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion kite-data/kite-data-core/src/main/java/org/kitesdk/data/spi/filesystem/FileSystemUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import com.google.common.collect.Iterables;
import com.google.common.collect.Lists;
import java.io.IOException;
import java.io.FileNotFoundException;
import java.net.URI;
import java.util.Collection;
import java.util.List;
Expand Down Expand Up @@ -239,7 +240,12 @@ private static boolean cleanlyDelete(FileSystem fs, Path root, Path path, boolea
if (stats == null || stats.length == 0) {
// dir is empty and should be removed
LOG.debug("Deleting empty path {}", current);
deleted = fs.delete(current, true) || deleted;
try{
deleted = fs.delete(current, true) || deleted;
}
catch(FileNotFoundException ex){
// safely ignored, since anther job just deleted this directory
}
} else {
// all parent directories will be non-empty
break;
Expand Down