Skip to content

Replace 'Arrays.asList' for single element lists #6388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025

Conversation

solth
Copy link
Member

@solth solth commented Jan 29, 2025

This pull request resolves some performance related code issues by replacing calls to Arrays.asList() with only one argument by either Collections.singletonList() or List.of(), depending on whether the resulting list should be immutable or not.

@solth solth changed the title Replace 'Arrays.asList' for single element lists with appr Replace 'Arrays.asList' for single element lists Jan 29, 2025
@solth solth requested a review from matthias-ronge January 31, 2025 10:55
@solth solth force-pushed the single-element-lists branch from f13ce6c to caa5377 Compare February 4, 2025 08:29
@solth solth force-pushed the single-element-lists branch from caa5377 to b43c942 Compare February 17, 2025 16:32
@solth solth force-pushed the single-element-lists branch from b43c942 to 383c55e Compare April 3, 2025 06:28
@solth solth force-pushed the single-element-lists branch from 383c55e to eb905f0 Compare April 8, 2025 07:11
@solth solth merged commit 2bf5416 into kitodo:main May 1, 2025
5 checks passed
@solth solth deleted the single-element-lists branch May 1, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant