fix: ensure we import and map default theme on KvToolTip, add new themes#601
Merged
fix: ensure we import and map default theme on KvToolTip, add new themes#601
Conversation
dyersituations
approved these changes
Jul 10, 2025
michelleinez
approved these changes
Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we weren't importing or mapping the
defaulttheme for our KvToolTip. That theme is supposed to be used by "default" so it's always selected. It's a bit of a long-shot to think this will fix the issue with using it in rtp-nuxt but it might!Otherwise, we now import the default theme and map it. I've also imported and mapped all our new themes and updated the story with a selector control so you can test them all out. Also, made a fix for the arrow color which wasn't getting applied.