Skip to content

feat: update KvSelect height and weight #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 11, 2025
Merged

feat: update KvSelect height and weight #602

merged 2 commits into from
Jul 11, 2025

Conversation

christian14b
Copy link
Collaborator

Style changes to KvSelect:

  • Reducing height and setting font weight to medium

@christian14b christian14b requested a review from a team July 11, 2025 19:52
@christian14b
Copy link
Collaborator Author

@dyersituations @mcstover seems like this change might affect in other components. Not sure if we want to handle this using props. For instance:

image

@dyersituations
Copy link
Collaborator

@dyersituations @mcstover seems like this change might affect in other components. Not sure if we want to handle this using props. For instance:

image

Good call to test locally. I wonder if we can do this:

  • change font weight here
  • change dropdown height only for quick filters for now?

@christian14b christian14b reopened this Jul 11, 2025
@christian14b christian14b merged commit 7bfe332 into main Jul 11, 2025
4 of 6 checks passed
@christian14b christian14b deleted the minor-styles-changes-in-select-dropdown-MP-1569 branch July 11, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dyersituations dyersituations dyersituations approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christian14b @dyersituations