Skip to content

Comments

feat: update KvSelect height and weight#602

Merged
christian14b merged 2 commits intomainfrom
minor-styles-changes-in-select-dropdown-MP-1569
Jul 11, 2025
Merged

feat: update KvSelect height and weight#602
christian14b merged 2 commits intomainfrom
minor-styles-changes-in-select-dropdown-MP-1569

Conversation

@christian14b
Copy link
Collaborator

Style changes to KvSelect:

  • Reducing height and setting font weight to medium

@christian14b christian14b requested a review from a team July 11, 2025 19:52
@christian14b
Copy link
Collaborator Author

@dyersituations @mcstover seems like this change might affect in other components. Not sure if we want to handle this using props. For instance:

image

@dyersituations
Copy link
Collaborator

@dyersituations @mcstover seems like this change might affect in other components. Not sure if we want to handle this using props. For instance:

image

Good call to test locally. I wonder if we can do this:

  • change font weight here
  • change dropdown height only for quick filters for now?

@christian14b christian14b merged commit 7bfe332 into main Jul 11, 2025
4 of 6 checks passed
@christian14b christian14b deleted the minor-styles-changes-in-select-dropdown-MP-1569 branch July 11, 2025 20:46
@mcstover
Copy link
Collaborator

@christian14b @dyersituations I've accepted the results from this pr as baseline but wanted to note that while we fixed the select height here we could probably refine the text positioning a bit more. It's most obvious in the loan card select.

image

Most of the baseline changes were related to the text being a little higher within the select.

@christian14b
Copy link
Collaborator Author

@christian14b @dyersituations I've accepted the results from this pr as baseline but wanted to note that while we fixed the select height here we could probably refine the text positioning a bit more. It's most obvious in the loan card select.

image

Most of the baseline changes were related to the text being a little higher within the select.

Thanks @mcstover! I'll create a ticket to work on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants