feat: borrowers carousel headline update #6116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
roger-in-kiva
commented
Jul 1, 2025
roger-in-kiva
commented
- borrowers carousel headline update
- https://kiva.atlassian.net/browse/MP-1733
There was a problem hiding this comment.
Pull Request Overview
This PR updates the borrower carousel’s headline text to remove “right now” and to use the totalLoans count for the plural case.
- Removed “right now” from both singular and plural headlines
- Switched plural count from
activeLoans.value.lengthtototalLoans.value
Comments suppressed due to low confidence (1)
src/components/MyKiva/BorrowerCarousel.vue:217
- Add or update unit tests for the computed
titleto verify both the singular (1 loan) and plural (>1 loans) outputs, and ensure the phrase “right now” is no longer present.
return `You’re <u>changing ${totalLoans.value} lives</u>!`;
dyersituations
approved these changes
Jul 1, 2025
kiva-robot
added a commit
that referenced
this pull request
Jul 14, 2025
## [3.24.0-rc.1](v3.23.0...v3.24.0-rc.1) (2025-07-14) ### 🎉 New Features * add basketItems at LoanFinding ([4879a6a](4879a6a)) * add huge lending amounts to LBC page ([4601619](4601619)) * add isBpModalEnabled mixin ([5d78d41](5d78d41)) * add more loan status and copy changes to what's next ([cdfd429](cdfd429)) * add show-loan-details and custom-loan-details ([dda4449](dda4449)) * add sidesheet to LBC page ([4e3c769](4e3c769)) * addToBasket now functioning ([db94fc0](db94fc0)) * **blog-carousel:** add latest blog carousel ([060ae69](060ae69)) * **blog-carousel:** add latest blog carousel ([7ca5726](7ca5726)) * **blog-carousel:** add latest blog carousel ([5348b94](5348b94)) * borrowers carousel headline update ([#6116](#6116)) ([97dbbd5](97dbbd5)) * compact borrower card and show bp sidesheet on cta ([e269a39](e269a39)) * improve sidesheet reactivity to loan adding ([a7f6b4c](a7f6b4c)) * journeys carousel update ([#6110](#6110)) ([c0589f9](c0589f9)) * make first working copy of borrower sidesheet ([7342e94](7342e94)) * mykiva borrowers carousel updated ([#6114](#6114)) ([57218b0](57218b0)) * open sidesheet when leaving a comment ([6cde8bc](6cde8bc)) * show repayment summary card with correct copy and triple image ([a3ac890](a3ac890)) * show repayment summary card with correct copy and triple image ([655e59b](655e59b)) * show repayment summary card with correct copy and triple image ([2b6fa5f](2b6fa5f)) * show repayment summary card with correct copy and triple image ([56406c4](56406c4)) * show repayment summary card with correct copy and triple image ([159f98b](159f98b)) * show repayment summary card with correct copy and triple image ([6895175](6895175)) * show repayment summary card with correct copy and triple image ([bf52f98](bf52f98)) * show repayment summary card with correct copy and triple image ([eaa4a11](eaa4a11)) * show repayment summary card with correct copy and triple image ([7f0c09e](7f0c09e)) * show repayment summary card with correct copy and triple image ([685dc38](685dc38)) * show repayment summary card with correct copy and triple image ([e6be5bf](e6be5bf)) * show repayment summary card with correct copy and triple image ([3773759](3773759)) ### 🐛 Bugfixes * add BP emitters and listeners ([33954df](33954df)) * add isBpModalEnabled prop to LoanFinding ([cdab402](cdab402)) * add lendAmount to ATB emit ([cf91c71](cf91c71)) * add loading as prop from BorrowerProfileContent ([97b4354](97b4354)) * add loading prop to LoanProgress ([be893aa](be893aa)) * add logReadQueryError to mixin ([1173233](1173233)) * add missing search bar test mocks ([10da540](10da540)) * add partName to borroweRProfileSideSheet graphql query ([1e6b14f](1e6b14f)) * add tracking to nav search bar ([23b8417](23b8417)) * add y margin to WhySpecial to fix text cutoff ([d0197ca](d0197ca)) * add z-index tailwind class ([2b72a7d](2b72a7d)) * apply conditional render to lenders and teams based on count ([37e6114](37e6114)) * apply extended borrower-profile-exp-mixin ([7ce58eb](7ce58eb)) * apply logFomatter, fix tailwind classes, apply unsubscribe ([237b995](237b995)) * apply minor loading style fixes ([c67fb3e](c67fb3e)) * apply mixin and kvTrackEvent fixes ([1290e36](1290e36)) * apply review fixes ([37c1e10](37c1e10)) * apply style fixes ([45af44c](45af44c)) * apply style fixes ([84eb62c](84eb62c)) * apply tw-bg-secondary to BorrowerSideSheetContent ([99f60c9](99f60c9)) * **blog-carousel:** ensure hydration, defensive rendering, and card click tracking ([57eb3cf](57eb3cf)) * change category ([ebe6d4a](ebe6d4a)) * change menu logic to fundraising status ([62e0c01](62e0c01)) * fix dimensions of controls template ([8d54e99](8d54e99)) * fix local GraphQL resolvers ([e35690a](e35690a)) * fix minor lifecycle warnings ([33f29cf](33f29cf)) * fix minor style issue when showSingleArray is active ([b879648](b879648)) * fix missing merge resolve ([71f5e41](71f5e41)) * fix missing return setup isFundraising variable in BorrowerSideSheetContent ([f7be86a](f7be86a)) * fix props usage in MyKivaPageContent ([f5496a1](f5496a1)) * fix SideSheetWrapper and implement in MyKivaPageContent ([e0bc87f](e0bc87f)) * fix this.router to this. ([de30264](de30264)) * fix type declaration for function in BorrowerSideSheetWrapper ([deb9d07](deb9d07)) * implement logFormatter ([2c3f0d6](2c3f0d6)) * invert isguest boolean logic ([9a53f2c](9a53f2c)) * loanId variable mutation ([c85d883](c85d883)) * make nav header sticky ([f9623c1](f9623c1)) * merge basket modal mixin into borrower-profile mixin ([24d9287](24d9287)) * merge is-bp-modal-enabled-mixin into bp-exp-mixin ([85a7f51](85a7f51)) * missing flag in sidesheet wrapper ([ea6fc47](ea6fc47)) * optional chaining for logged out user ([bc37762](bc37762)) * paying back delinquent case was already handled with paying back status ([a11d106](a11d106)) * redirect to help kiva page ([7380cf8](7380cf8)) * reintroduce add-to-basket mixin, extend borrower-profile-exp-mixin ([3aa06d0](3aa06d0)) * remove animationSourceElement ([b466d43](b466d43)) * remove console logs ([9d58306](9d58306)) * remove duplicate loansIdsInBasket values ([df5089b](df5089b)) * remove enableHugeAmount props ([7523574](7523574)) * remove leave a comment option if loan is funded ([5fafc15](5fafc15)) * remove redundant addToBasket calls in ATB emits ([b49e6c1](b49e6c1)) * remove unused graphql query ([2df3a74](2df3a74)) * remove unused status ([41fd9d3](41fd9d3)) * removing unused addToBasket ([9196db7](9196db7)) * reset receipt value after you click close lightbox ([ffd967a](ffd967a)) * run initializeIsBpModalEnabledExp on component mount ([8a420b1](8a420b1)) * show transactions and cards in two different arrays ([e507775](e507775)) * simplify check for isBpModalEnabled ([d36f911](d36f911)) * solve conflicts ([2af3b12](2af3b12)) * solve conflicts ([0ee5711](0ee5711)) * style spacing fix ([1fc48fb](1fc48fb)) * tabs needed to be rendered so ref can be defined ([090fae7](090fae7)) * update basic needs filters ([8d3c53d](8d3c53d)) * use add-to-basket-exp-mixin ([78e5d5d](78e5d5d)) ### 🪚 Refactors * clean up some code and remove unnecessary computed ([a444acb](a444acb)) * create borrower sidesheet wrapper to handle add to basket method ([dde6350](dde6350)) * loan next steps ([d5dbda5](d5dbda5)) ### 💅 Code Style Changes * add comment for timeout context ([9f0a3a5](9f0a3a5)) * add id to graphql query ([3cdb4f5](3cdb4f5)) * remove length zero no unit code ([21782bb](21782bb)) ### 🧹 Chores * more work, still not working ([fa2a084](fa2a084)) * still working on it all ([bc12d3c](bc12d3c))
|
🎉 This PR is included in version 3.24.0-rc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
kiva-robot
added a commit
that referenced
this pull request
Jul 14, 2025
## [3.24.0](v3.23.0...v3.24.0) (2025-07-14) ### 🎉 New Features * add basketItems at LoanFinding ([4879a6a](4879a6a)) * add huge lending amounts to LBC page ([4601619](4601619)) * add isBpModalEnabled mixin ([5d78d41](5d78d41)) * add more loan status and copy changes to what's next ([cdfd429](cdfd429)) * add show-loan-details and custom-loan-details ([dda4449](dda4449)) * add sidesheet to LBC page ([4e3c769](4e3c769)) * addToBasket now functioning ([db94fc0](db94fc0)) * **blog-carousel:** add latest blog carousel ([060ae69](060ae69)) * **blog-carousel:** add latest blog carousel ([7ca5726](7ca5726)) * **blog-carousel:** add latest blog carousel ([5348b94](5348b94)) * borrowers carousel headline update ([#6116](#6116)) ([97dbbd5](97dbbd5)) * compact borrower card and show bp sidesheet on cta ([e269a39](e269a39)) * improve sidesheet reactivity to loan adding ([a7f6b4c](a7f6b4c)) * journeys carousel update ([#6110](#6110)) ([c0589f9](c0589f9)) * make first working copy of borrower sidesheet ([7342e94](7342e94)) * mykiva borrowers carousel updated ([#6114](#6114)) ([57218b0](57218b0)) * open sidesheet when leaving a comment ([6cde8bc](6cde8bc)) * show repayment summary card with correct copy and triple image ([a3ac890](a3ac890)) * show repayment summary card with correct copy and triple image ([655e59b](655e59b)) * show repayment summary card with correct copy and triple image ([2b6fa5f](2b6fa5f)) * show repayment summary card with correct copy and triple image ([56406c4](56406c4)) * show repayment summary card with correct copy and triple image ([159f98b](159f98b)) * show repayment summary card with correct copy and triple image ([6895175](6895175)) * show repayment summary card with correct copy and triple image ([bf52f98](bf52f98)) * show repayment summary card with correct copy and triple image ([eaa4a11](eaa4a11)) * show repayment summary card with correct copy and triple image ([7f0c09e](7f0c09e)) * show repayment summary card with correct copy and triple image ([685dc38](685dc38)) * show repayment summary card with correct copy and triple image ([e6be5bf](e6be5bf)) * show repayment summary card with correct copy and triple image ([3773759](3773759)) ### 🐛 Bugfixes * add BP emitters and listeners ([33954df](33954df)) * add isBpModalEnabled prop to LoanFinding ([cdab402](cdab402)) * add lendAmount to ATB emit ([cf91c71](cf91c71)) * add loading as prop from BorrowerProfileContent ([97b4354](97b4354)) * add loading prop to LoanProgress ([be893aa](be893aa)) * add logReadQueryError to mixin ([1173233](1173233)) * add missing search bar test mocks ([10da540](10da540)) * add partName to borroweRProfileSideSheet graphql query ([1e6b14f](1e6b14f)) * add tracking to nav search bar ([23b8417](23b8417)) * add y margin to WhySpecial to fix text cutoff ([d0197ca](d0197ca)) * add z-index tailwind class ([2b72a7d](2b72a7d)) * apply conditional render to lenders and teams based on count ([37e6114](37e6114)) * apply extended borrower-profile-exp-mixin ([7ce58eb](7ce58eb)) * apply logFomatter, fix tailwind classes, apply unsubscribe ([237b995](237b995)) * apply minor loading style fixes ([c67fb3e](c67fb3e)) * apply mixin and kvTrackEvent fixes ([1290e36](1290e36)) * apply review fixes ([37c1e10](37c1e10)) * apply style fixes ([45af44c](45af44c)) * apply style fixes ([84eb62c](84eb62c)) * apply tw-bg-secondary to BorrowerSideSheetContent ([99f60c9](99f60c9)) * **blog-carousel:** ensure hydration, defensive rendering, and card click tracking ([57eb3cf](57eb3cf)) * change category ([ebe6d4a](ebe6d4a)) * change menu logic to fundraising status ([62e0c01](62e0c01)) * fix datasorurce for blog carousel ([c7c57b1](c7c57b1)) * fix datasorurce for blog carousel ([8d2d4a9](8d2d4a9)) * fix dimensions of controls template ([8d54e99](8d54e99)) * fix local GraphQL resolvers ([e35690a](e35690a)) * fix minor lifecycle warnings ([33f29cf](33f29cf)) * fix minor style issue when showSingleArray is active ([b879648](b879648)) * fix missing merge resolve ([71f5e41](71f5e41)) * fix missing return setup isFundraising variable in BorrowerSideSheetContent ([f7be86a](f7be86a)) * fix props usage in MyKivaPageContent ([f5496a1](f5496a1)) * fix SideSheetWrapper and implement in MyKivaPageContent ([e0bc87f](e0bc87f)) * fix this.router to this. ([de30264](de30264)) * fix type declaration for function in BorrowerSideSheetWrapper ([deb9d07](deb9d07)) * hide next steps in borrower side sheet for recommended loans carousel ([1001623](1001623)) * implement logFormatter ([2c3f0d6](2c3f0d6)) * invert isguest boolean logic ([9a53f2c](9a53f2c)) * loanId variable mutation ([c85d883](c85d883)) * make nav header sticky ([f9623c1](f9623c1)) * merge basket modal mixin into borrower-profile mixin ([24d9287](24d9287)) * merge is-bp-modal-enabled-mixin into bp-exp-mixin ([85a7f51](85a7f51)) * missing flag in sidesheet wrapper ([ea6fc47](ea6fc47)) * optional chaining for logged out user ([bc37762](bc37762)) * paying back delinquent case was already handled with paying back status ([a11d106](a11d106)) * redirect to help kiva page ([7380cf8](7380cf8)) * reintroduce add-to-basket mixin, extend borrower-profile-exp-mixin ([3aa06d0](3aa06d0)) * remove animationSourceElement ([b466d43](b466d43)) * remove console logs ([9d58306](9d58306)) * remove duplicate loansIdsInBasket values ([df5089b](df5089b)) * remove enableHugeAmount props ([7523574](7523574)) * remove leave a comment option if loan is funded ([5fafc15](5fafc15)) * remove redundant addToBasket calls in ATB emits ([b49e6c1](b49e6c1)) * remove unused graphql query ([2df3a74](2df3a74)) * remove unused status ([41fd9d3](41fd9d3)) * removing unused addToBasket ([9196db7](9196db7)) * reset receipt value after you click close lightbox ([ffd967a](ffd967a)) * resolve console warning for blog carousel ([f514b22](f514b22)) * run initializeIsBpModalEnabledExp on component mount ([8a420b1](8a420b1)) * show transactions and cards in two different arrays ([e507775](e507775)) * simplify check for isBpModalEnabled ([d36f911](d36f911)) * solve conflicts ([2af3b12](2af3b12)) * solve conflicts ([0ee5711](0ee5711)) * style spacing fix ([1fc48fb](1fc48fb)) * tabs needed to be rendered so ref can be defined ([090fae7](090fae7)) * update basic needs filters ([8d3c53d](8d3c53d)) * use add-to-basket-exp-mixin ([78e5d5d](78e5d5d)) ### 🪚 Refactors * clean up some code and remove unnecessary computed ([a444acb](a444acb)) * create borrower sidesheet wrapper to handle add to basket method ([dde6350](dde6350)) * loan next steps ([d5dbda5](d5dbda5)) ### 💅 Code Style Changes * add comment for timeout context ([9f0a3a5](9f0a3a5)) * add id to graphql query ([3cdb4f5](3cdb4f5)) * remove length zero no unit code ([21782bb](21782bb)) ### 🧹 Chores * more work, still not working ([fa2a084](fa2a084)) * **release:** 3.24.0-rc.1 [skip ci] ([54e2bcd](54e2bcd)), closes [#6116](#6116) [#6110](#6110) [#6114](#6114) * **release:** 3.24.0-rc.2 [skip ci] ([194bb1f](194bb1f)) * **release:** 3.24.0-rc.3 [skip ci] ([b57bcd0](b57bcd0)) * still working on it all ([bc12d3c](bc12d3c))
|
🎉 This PR is included in version 3.24.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.