Skip to content

fix: mp-1730 / Add isBpModalEnabled prop to LoanFinding and associated components #6117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 4, 2025

Conversation

The-Best-Joke
Copy link
Contributor

Reinstates the usage of the isBpModalEnabled prop as the determinant for whether or not the KvSideSheet and showLoanDetails functionality are active in the LBC page.

@The-Best-Joke The-Best-Joke requested a review from a team July 1, 2025 18:36
@The-Best-Joke The-Best-Joke self-assigned this Jul 1, 2025
@roger-in-kiva
Copy link
Collaborator

As we'll use same functionality on my kiva page, useful having this flag in a mixin, similar this:
https://github.com/kiva/ui/blob/main/src/plugins/add-to-basket-exp-mixin.js

Copy link
Collaborator

@dyersituations dyersituations left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment about initializeIsBpModalEnabledExp

@The-Best-Joke The-Best-Joke merged commit 6e30c2b into main Jul 4, 2025
5 checks passed
@The-Best-Joke The-Best-Joke deleted the MP-1730 branch July 4, 2025 17:40
@kiva-robot
Copy link
Collaborator

🎉 This PR is included in version 3.24.0-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@kiva-robot
Copy link
Collaborator

🎉 This PR is included in version 3.24.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants