Closed
Conversation
AndreMiras
reviewed
Aug 20, 2025
| def get_recipe_env(self, arch): | ||
| env = super().get_recipe_env(arch) | ||
| # Ensure cmake is found inside hostpython | ||
| env["PATH"] = "/usr/bin:" + env.get("PATH", "") |
Member
There was a problem hiding this comment.
This is weird, why would you need to add /usr/bin to the PATH, that should come as the default
AndreMiras
requested changes
Aug 20, 2025
Member
|
Actually this recipe is not even required, it can be replaced with one line: hostpython_prerequisites = ['pybind11'] |
Contributor
Exactly 😅 |
Member
|
Sweet, thanks for the heads up, someone wants to make a pull request to remove the recipe then? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3188