Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sandbox issue for macOS CI unit tests #1076

Merged
merged 6 commits into from
Jan 17, 2025
Merged

Fix sandbox issue for macOS CI unit tests #1076

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cd26c29
Fix sandbox issue for macOS CI unit tests
BPerlakiH Jan 12, 2025
729b77c
Add remanining capabilities
BPerlakiH Jan 12, 2025
5ce39b9
Ignore generated file
BPerlakiH Jan 12, 2025
8abd9c7
Remove ignored file
BPerlakiH Jan 12, 2025
73dd5a2
Only disable sandboxing ignore the rest for unit tests
BPerlakiH Jan 13, 2025
723ccff
Turn off code signing for macOS unit tests
BPerlakiH Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ jobs:

- name: Run Unit Tests on macOS
if: matrix.platform == 'macOS'
run: xcodebuild test -scheme Kiwix -destination 'platform=macOS'
run: xcodebuild test -scheme Kiwix -destination 'platform=macOS' CODE_SIGNING_ALLOWED=NO

- name: Upload code coverage
uses: codecov/[email protected]
Expand Down
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ Libraries
# ignore xcode project files, they are now generated by XcodeGen
*.xcodeproj
Support/Kiwix.entitlements
Support/Kiwix-unitTest.entitlements

# ignore the lock file, it is not working the same way as lock files in other tools
Brewfile.lock.json
Expand Down
7 changes: 7 additions & 0 deletions project.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,13 @@ targets:
PRODUCT_BUNDLE_IDENTIFIER: org.kiwix.Tests
TEST_HOST: $(BUILT_PRODUCTS_DIR)/Kiwix.app/$(BUNDLE_EXECUTABLE_FOLDER_PATH)/Kiwix
BUNDLE_LOADER: $(TEST_HOST)
entitlements:
path: Support/Kiwix-unitTest.entitlements
properties:
com.apple.security.app-sandbox: false
# from macOS 14, sandbox and unit test are not working together on CI
# a pop up appears that needs user acceptance
# see: https://developer.apple.com/documentation/security/accessing-files-from-the-macos-app-sandbox
sources:
- path: Tests
dependencies:
Expand Down
Loading