Skip to content

Make random button optional for custom apps #1180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025

Conversation

BPerlakiH
Copy link
Collaborator

Implements the common code part of: kiwix/kiwix-apple-custom#98

@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2025

Codecov Report

Attention: Patch coverage is 46.15385% with 7 lines in your changes missing coverage. Please review.

Project coverage is 23.23%. Comparing base (26d1e3f) to head (b414934).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
Views/BuildingBlocks/ArticleActions.swift 0.00% 6 Missing ⚠️
Views/Buttons/ArticleShortcutButtons.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1180      +/-   ##
==========================================
- Coverage   24.57%   23.23%   -1.34%     
==========================================
  Files         137      137              
  Lines        7228     7229       +1     
==========================================
- Hits         1776     1680      -96     
- Misses       5452     5549      +97     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kelson42 kelson42 force-pushed the 98-make-random-button-optional-for-custom-apps branch from d4077fa to b414934 Compare April 24, 2025 04:32
@kelson42 kelson42 merged commit fedd382 into main Apr 24, 2025
7 checks passed
@kelson42 kelson42 deleted the 98-make-random-button-optional-for-custom-apps branch April 24, 2025 04:32
@kelson42 kelson42 added this to the 3.9.0 milestone Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants