Reflect offline state in dowloads

[BPerlakiH]

Fixes: #1419

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.59%. Comparing base (3b1cce6) to head (82be961).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1421   +/-   ##
=======================================
  Coverage   92.59%   92.59%           
=======================================
  Files          18       18           
  Lines         878      878           
=======================================
  Hits          813      813           
  Misses         65       65           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[kelson42]

I don't think this is a good idea to introduced this new status "offline" because it is everything but clear what is offline.

The status has to be "paused" like requested in the issue.

One question left open would be if the user needs additionally (to the "paused" status) to be informed that the underlying reason is the device been offline. I don't think this is necessary.

If you believe that, to the contrary, this is important. We could introduce in the detailed download view, we could replace the "Pause" information item with "Pause (device is offline)".

[BPerlakiH]

I think the confusion will come from the fact that the download task itself can be paused and resumed, regardless if the user is online or offline.

So let's say, I want to download 2 very large files, and press download on both of them.
After a while I realize it will take a long time, but I want one of them more, so I put the other download on pause (to use my full band-width on the first).
In this situation, after pressing pause, the other file will be marked as "paused", and the first one will continue downloading (hopefully quicker).
Now with the above requirements, if I loose my internet connection, both files will be marked as "paused", and I won't know why.

The other confusing part is that, if I don't have internet connection, I should not have the option to "resume" a download, but that's not going to be clear either.

So in a state machine description, we have:

A) task paused
B) task resumed:
   B1) online
   B2) offline

Maybe this "offline" naming is not clear enough and needs to be changed.
I think re-using the "pause" is not good either, if you look at the screenshot we still have an active "pause" button.

If I understand your idea correctly, that would mean that we try to squeeze our current 3 states:

- paused
- resumed online
- resumed offline

into 2 (visible) states:

- paused*
- resumed

with the *, that if I am offline I won't be able to "resume", and once I get back online it will magically change back to "resumed".

So far the user had the option to "pause" and "resume", now we would magically take away this option from them (if they are offline), without a clear explanation. I think that is confusing.

[kelson42]

Decision (when device is offline):

• Status label should ""Paused (device is offline)"
• (Pause/Resume) Button label shuld be "Resume" but button should be greyed

[codefactor-io]

Imports should be unique

Suggested change

import Combine

[BPerlakiH]

Closing in favor of: #1424