Skip to content

Conversation

@kelson42
Copy link
Contributor

@kelson42 kelson42 commented Jan 4, 2026

  • Change the secret name to use new secret
  • Improve the naming of a few variables

@kelson42 kelson42 added this to the 3.12.0 milestone Jan 4, 2026
@kelson42 kelson42 requested a review from rgaudin January 4, 2026 06:41
@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.59%. Comparing base (3b1cce6) to head (eeb4f00).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1423   +/-   ##
=======================================
  Coverage   92.59%   92.59%           
=======================================
  Files          18       18           
  Lines         878      878           
=======================================
  Hits          813      813           
  Misses         65       65           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BPerlakiH
Copy link
Collaborator

@kelson42 We have the same variables on the custom-apps side as well, although those seems not to be in use at the moment (I suspect mainly due to the fact that we do not upload DMGs for custom apps).
Maybe we should update them as well, for consistency:
https://github.com/kiwix/kiwix-apple-custom/blob/4168c85ddf3444b0bcd4d8d7c6774575bf0ae9b1/.github/workflows/cd.yml#L13
https://github.com/kiwix/kiwix-apple-custom/blob/4168c85ddf3444b0bcd4d8d7c6774575bf0ae9b1/.github/workflows/ci.yml#L16

@kelson42 kelson42 merged commit 3f24a09 into main Jan 6, 2026
8 checks passed
@kelson42 kelson42 deleted the ssh-key-renaming branch January 6, 2026 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants