Skip to content

Conversation

@kixelated
Copy link
Owner

@kixelated kixelated commented Oct 17, 2025

Summary by CodeRabbit

  • Chores
    • Centralized dependency declarations at the workspace level for consistent versioning across packages.
    • Updated package references to use workspace resolution instead of local path pins.
    • Adjusted build helpers to allow running fixes and linting on dirty worktrees and to consistently target WASM-related packages.

@coderabbitai
Copy link

coderabbitai bot commented Oct 17, 2025

Walkthrough

The PR adds a [workspace.dependencies] section to the root Cargo.toml declaring web-transport-trait (path = "web-transport-trait", version = "0.1") and web-transport-proto (path = "web-transport-proto", version = "0.2"). Member Cargo.toml files for web-transport-quinn, web-transport-wasm, and web-transport-ws switch their references to those crates to workspace = true instead of local path/version entries. The justfile targets for fix and WASM now add --allow-dirty and explicit -p package flags for the wasm-related commands.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The PR title "Use workspace dependencies" directly and accurately describes the primary change in this changeset. The core objective is to migrate the codebase from local path-based dependencies to workspace-based dependencies, which is accomplished by adding a [workspace.dependencies] section to the root Cargo.toml and updating dependency declarations across multiple packages (web-transport-quinn, web-transport-wasm, and web-transport-ws) to use workspace = true. The title is concise, specific, and clearly communicates the main intent without unnecessary details. Secondary changes to the justfile (adding --allow-dirty flags) are appropriately omitted as they are not the primary focus of the PR.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch workspace-deps

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8723997 and c321fd9.

📒 Files selected for processing (2)
  • Cargo.toml (1 hunks)
  • justfile (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • Cargo.toml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build
🔇 Additional comments (2)
justfile (2)

55-56: LGTM: Consistent addition of --allow-dirty flag.

The addition of --allow-dirty to both cargo fix and cargo clippy commands is appropriate for development workflows, allowing developers to run fixes even with uncommitted changes. This pairs well with the existing --allow-staged flag.


59-62: LGTM: Consistent WASM-target flag addition.

The addition of --allow-dirty to the WASM-specific fix and clippy commands maintains consistency with the workspace-level commands above. This ensures a uniform development experience across all targets.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kixelated kixelated enabled auto-merge (squash) October 17, 2025 18:09
@kixelated kixelated merged commit 38c2dc2 into main Oct 17, 2025
1 check passed
@kixelated kixelated deleted the workspace-deps branch October 17, 2025 18:11
@github-actions github-actions bot mentioned this pull request Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants