Change web-transport-trait::Session::closed() to return a Result

[kixelated]

No description provided.

[coderabbitai]

Warning

Rate limit exceeded

@kixelated has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 13 minutes and 40 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 38c2dc2 and 1a8d2a4.

📒 Files selected for processing (5)

• web-transport-quinn/src/session.rs (1 hunks)
• web-transport-trait/src/lib.rs (1 hunks)
• web-transport-wasm/src/session.rs (1 hunks)
• web-transport-ws/examples/server.rs (1 hunks)
• web-transport-ws/src/session.rs (1 hunks)

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch closed-result

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[rom1v]

You could maybe also return Ok for ApplicationClosed(_) (not sure).

[kixelated]

ApplicationClosed means the peer closed the connection via session.close(code, reason). Maaaybe we could return Ok((code, reason)) instead of () but they definitely shouldn't be swallowed.