net: openthread: Added config for OpenThread version selection. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Config options used for selecting OpenThread stack version were added. Signed-off-by: Kamil Kasperczyk <[email protected]>
| help | ||
| This option selects version of OpenThread stack. | ||
|
|
||
| config OPENTHREAD_THREAD_VERSION_1_1 |
There was a problem hiding this comment.
ok for me, but please also consider extending existing options and choose the best one? i.e rename OPENTHREAD_SOURCES by adding version (it originally it even had version in its name but I was asked to remove it for now as there is only 1.1 now ;) ). Please keep in mind that after some merges, that I hope will happen today, in NCS new option appears named OPENTHREAD_LIBRARY_1_1 so using OPENTHREAD_SOURCES_1_1 OPENTHREAD_SOURCES_1_2 might be worth considering.
MarekPorwisz
approved these changes
Jul 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Config options used for selecting OpenThread stack version
were added.
Signed-off-by: Kamil Kasperczyk [email protected]