[include/posix] Fix incorrect casting of timeval on zsock_timeval. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkasperczyk-no
force-pushed
the
timeval_fix
branch
3 times, most recently
from
3edb369
to
56154d8
Compare
Current implementation of select() method wrongly assumes that timeval type can be directly casted into zsock_timeval, while it's true only when using CONFIG_NET_SOCKETS_POSIX_NAMES. In other case i.e. using CONFIG_POSIX_API, timeval is provided by standard lib and mentioned two structure types have fields of different size, what leads to assigning them incorrect values. Signed-off-by: Kamil Kasperczyk <[email protected]>
kkasperczyk-no
force-pushed
the
timeval_fix
branch
from
56154d8
to
945b34a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation of select() method wrongly assumes that
timeval type can be directly casted into zsock_timeval, while it's
true only when using CONFIG_NET_SOCKETS_POSIX_NAMES. In other case
i.e. using CONFIG_POSIX_API, timeval is provided by standard lib
and mentioned two structure types have fields of different size,
what leads to assigning them incorrect values.
Signed-off-by: Kamil Kasperczyk [email protected]