-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement dict hints primitives #106
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jul 17, 2024
zmalatrax
force-pushed
the
feat/implement-dict-hint-base
branch
from
July 30, 2024 08:28
6c2cd53
to
7c5a04d
Compare
enitrat
reviewed
Jul 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering that this implementation is the "front-door" to the CairoVM, I would double-down on explicit and well-formed JSDoc for every functions
enitrat
reviewed
Jul 30, 2024
Co-authored-by: Mathieu <[email protected]>
zmalatrax
force-pushed
the
feat/implement-dict-hint-base
branch
from
July 30, 2024 15:27
35ab62f
to
c489739
Compare
enitrat
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #102, closes #103, closes #104, closes #105, closes #107, closes #108, closes #109, closes #110, closes #111, closes #112, closes #113, closes #114, closes #115, closes #116, closes #117, closes #118
To execute and implement hints related to dictionnaries, a few things must be implemented first:
ScopeManager
, to access variables across different hints (used inAssertLeFindSmallArc
,AssertLeIsFirstArcExcluded
andAssertLeIsSecondArcExcluded
).DictManager
a map of dictionnaries, where allocated dictionnaries are stored during executionSquashedDictManager
, handles the squashing of the dictionnaries, needed to end the run and generate correct traces.Once done, dictionnaries can be handled.
AllocFelt252Dict
Felt252DictEntryInit
dict.cairo
)Felt252DictEntryUpdate
dict.cairo
)GetSegmentArenaIndex
InitSquashData
GetCurrentAccessIndex
ShouldSkipSquashLoop
GetCurrentAccessDelta
ShouldContinueSquashLoop
GetNextDictKey
AssertLeFindSmallArcs
AssertLeIsFirstArcExcluded
AssertLeIsSecondArcExcluded