feat: brainfuck prover backbone #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22
Still needs to add the
verify_brainfuckfunction.The constant$2^{20} \approx 10^6$ steps.
MAX_LOG_ROWSis arbitrarily set to 20, taken from stwo-cairo (it means we prove execution of maxIs adding a sanity check on the lookup sum during the proof generation a best practice ? (This check is made by the verifier, verifying it during the proof generation allows to be sure that this check will pass for the proof generated by
prove_brainfuck)