This repository was archived by the owner on Jan 22, 2023. It is now read-only.
fix Backup/Restore preferences on Android 11+ #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etExternalFilesDir, fixes backup/restore preferences
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small fix which removes the deprecated
getExternalStorageDirectoryin favour of the (scoped)getExternalFilesDirThis fixes the backup/restore preferences functionality on Android 11+.
As I'm not really versed in Android Storage best-practices and think that the new scoped, App specific, Storage is not optimal as the backup file will be deleted when you uninstall the App and the backup File is not easily accessible to other Apps I have marked this as a draft, suggested changes/improvements are more than welcome.
There might also be a few other, probably unrelated cosmetic bugs regarding the restore procedure, e.g. if i create a backup, change the theme from dark to light, restore the backup and then try to change the theme again to the light version the app is displayed with the dark theme but the selected entry is already/still the light theme.