[release-1.14] Allow enabling sarama logging and disabling client pool (#4103) #4107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsions#4103) Add 3 new environment variables: ``` ENABLE_SARAMA_LOGGER (default: false) ENABLE_SARAMA_DEBUG_LOGGER (default: false) ENABLE_SARAMA_CLIENT_POOL (default: true) ``` Signed-off-by: Pierangelo Di Pilato <[email protected]>
knative-prow
bot
added
area/control-plane
size/L
|
/retest |
Signed-off-by: Pierangelo Di Pilato <[email protected]>
|
@creydr sorry fixed an issue on this |
|
/test channel-reconciler-tests-sasl-ssl |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, matzew, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test integration-tests |
knative-prow
bot
merged commit 456b2d7
into
knative-extensions:release-1.14
34 checks passed
pierDipi
added a commit
to pierDipi/eventing-kafka-broker
that referenced
this pull request
Sep 24, 2024
knative-extensions#4103) (knative-extensions#4107) * Allow enabling sarama logging and disabling client pool (knative-extensions#4103) Add 3 new environment variables: ``` ENABLE_SARAMA_LOGGER (default: false) ENABLE_SARAMA_DEBUG_LOGGER (default: false) ENABLE_SARAMA_CLIENT_POOL (default: true) ``` Signed-off-by: Pierangelo Di Pilato <[email protected]> * Set GetKafkaClient Signed-off-by: Pierangelo Di Pilato <[email protected]> --------- Signed-off-by: Pierangelo Di Pilato <[email protected]>
pierDipi
added a commit
to pierDipi/eventing-kafka-broker
that referenced
this pull request
Sep 25, 2024
knative-extensions#4103) (knative-extensions#4107) * Allow enabling sarama logging and disabling client pool (knative-extensions#4103) Add 3 new environment variables: ``` ENABLE_SARAMA_LOGGER (default: false) ENABLE_SARAMA_DEBUG_LOGGER (default: false) ENABLE_SARAMA_CLIENT_POOL (default: true) ``` Signed-off-by: Pierangelo Di Pilato <[email protected]> * Set GetKafkaClient Signed-off-by: Pierangelo Di Pilato <[email protected]> --------- Signed-off-by: Pierangelo Di Pilato <[email protected]>
pierDipi
added a commit
to openshift-knative/eventing-kafka-broker
that referenced
this pull request
Sep 25, 2024
…ol and Upgrade knative.dev/eventing to latest 1.14 (#1279) * [release-1.14] Allow enabling sarama logging and disabling client pool (knative-extensions#4103) (knative-extensions#4107) * Allow enabling sarama logging and disabling client pool (knative-extensions#4103) Add 3 new environment variables: ``` ENABLE_SARAMA_LOGGER (default: false) ENABLE_SARAMA_DEBUG_LOGGER (default: false) ENABLE_SARAMA_CLIENT_POOL (default: true) ``` Signed-off-by: Pierangelo Di Pilato <[email protected]> * Set GetKafkaClient Signed-off-by: Pierangelo Di Pilato <[email protected]> --------- Signed-off-by: Pierangelo Di Pilato <[email protected]> * [release-1.14] Upgrade knative.dev/eventing to latest 1.14 (knative-extensions#4113) * Upgrade knative.dev/eventing to latest 1.14 Signed-off-by: Pierangelo Di Pilato <[email protected]> * Pass PodLister as expected Signed-off-by: Pierangelo Di Pilato <[email protected]> * Migrate to library SchedulerFunc to use the new signature Signed-off-by: Pierangelo Di Pilato <[email protected]> --------- Signed-off-by: Pierangelo Di Pilato <[email protected]> * Fix dispatcherPodLister and run make generate-release Signed-off-by: Pierangelo Di Pilato <[email protected]> * Clone the matching SO branch Signed-off-by: Pierangelo Di Pilato <[email protected]> * Add label selector to fix panic error Error: ``` 2024-09-25T10:41:51.023869929Z panic: Unable to fetch k8s.io/client-go/informers/core/v1.PodInformer with selector app.kubernetes.io/kind=kafka-dispatcher from context. ``` Signed-off-by: Pierangelo Di Pilato <[email protected]> --------- Signed-off-by: Pierangelo Di Pilato <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #4103