-
Notifications
You must be signed in to change notification settings - Fork 88
Refactor: Use config embedded in context #1360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Refactor: Use config embedded in context #1360
Conversation
Hi @ystkfujii. Thanks for your PR. I'm waiting for a knative-extensions member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ystkfujii The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1360 +/- ##
==========================================
- Coverage 72.46% 72.41% -0.05%
==========================================
Files 25 25
Lines 2099 2099
==========================================
- Hits 1521 1520 -1
- Misses 486 487 +1
Partials 92 92 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@@ -148,7 +147,7 @@ func (r *Reconciler) updateIngress(ctx context.Context, ingress *v1alpha1.Ingres | |||
logger.Infof("Updating Ingress") | |||
|
|||
if err := generator.UpdateInfoForIngress( | |||
ctx, r.caches, ingress, r.ingressTranslator, r.extAuthz); err != nil { | |||
ctx, r.caches, ingress, r.ingressTranslator); err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a configStore is configured, it appears to be embedded within the context.
Since it's configured, we should now be able to utilize the embedded configuration.
- Ref:
ConfigStore: configStore,
/ok-to-test |
Changes
/kind cleanup