Skip to content

Refactor: Use config embedded in context #1360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ystkfujii
Copy link
Contributor

@ystkfujii ystkfujii commented Jul 19, 2025

Changes

  • Removed the extAuthz field in Reconciler, instead utilizing the Config.Kourier.ExternalAuthz embedded within the context.

/kind cleanup

@knative-prow knative-prow bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 19, 2025
Copy link

knative-prow bot commented Jul 19, 2025

Hi @ystkfujii. Thanks for your PR.

I'm waiting for a knative-extensions member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 19, 2025
Copy link

knative-prow bot commented Jul 19, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ystkfujii
Once this PR has been reviewed and has the lgtm label, please assign gauron99 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from dsimansk, gauron99 and skonto July 19, 2025 07:24
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 19, 2025
Copy link

codecov bot commented Jul 19, 2025

Codecov Report

Attention: Patch coverage is 44.44444% with 5 lines in your changes missing coverage. Please review.

Project coverage is 72.41%. Comparing base (964f1c7) to head (15999f0).

Files with missing lines Patch % Lines
pkg/generator/generator.go 0.00% 2 Missing ⚠️
pkg/reconciler/ingress/controller.go 33.33% 2 Missing ⚠️
pkg/reconciler/ingress/ingress.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1360      +/-   ##
==========================================
- Coverage   72.46%   72.41%   -0.05%     
==========================================
  Files          25       25              
  Lines        2099     2099              
==========================================
- Hits         1521     1520       -1     
- Misses        486      487       +1     
  Partials       92       92              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@@ -148,7 +147,7 @@ func (r *Reconciler) updateIngress(ctx context.Context, ingress *v1alpha1.Ingres
logger.Infof("Updating Ingress")

if err := generator.UpdateInfoForIngress(
ctx, r.caches, ingress, r.ingressTranslator, r.extAuthz); err != nil {
ctx, r.caches, ingress, r.ingressTranslator); err != nil {
Copy link
Contributor Author

@ystkfujii ystkfujii Jul 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When a configStore is configured, it appears to be embedded within the context.

Since it's configured, we should now be able to utilize the embedded configuration.

@dsimansk
Copy link
Contributor

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants