Re-add GOVERNANCE.md removed in #1587, and add MAINTAINERS.md#1685
Merged
knative-prow[bot] merged 1 commit intoknative:mainfrom May 13, 2025
Merged
Re-add GOVERNANCE.md removed in #1587, and add MAINTAINERS.md#1685knative-prow[bot] merged 1 commit intoknative:mainfrom
knative-prow[bot] merged 1 commit intoknative:mainfrom
Conversation
Update ROLES.md to mention CNCF maintainer status for WG leads. Run prettier on ROLES.md
knative-prow
bot
added
approved
aliok
approved these changes
May 5, 2025
Member
aliok
left a comment
aliok
left a comment
There was a problem hiding this comment.
/lgtm
/approve
/hold
Hold for others.
Thanks Evan!
knative-prow
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aliok, evankanderson The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
LGTM |
Member
|
/hold cancel |
knative-prow
bot
removed
the
do-not-merge/hold
Member
|
thanks @evankanderson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
GOVERNANCE.md, deleted in Combine Steering and TO Committees #1587MAINTAINERS.mdsimply to point toROLES.mdand explain that we recognize multiple tiers of contribution.ROLES.mdto clarify that WG leads get CNCF maintainer status (and calendar scheduling permissions)prettieronROLES.mdbecause my setup automatically does that. Sorry for the reformatting!/kind documentation