Skip to content

Re-add GOVERNANCE.md removed in #1587, and add MAINTAINERS.md #1685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

evankanderson
Copy link
Member

Changes

  • 🧹 Re-add GOVERNANCE.md, deleted in Combine Steering and TO Committees #1587
  • 🧹 Add a MAINTAINERS.md simply to point to ROLES.md and explain that we recognize multiple tiers of contribution.
  • 🧹 Update ROLES.md to clarify that WG leads get CNCF maintainer status (and calendar scheduling permissions)
  • 🧹 🧹 Ran prettier on ROLES.md because my setup automatically does that. Sorry for the reformatting!

/kind documentation

Update ROLES.md to mention CNCF maintainer status for WG leads.
Run prettier on ROLES.md
@knative-prow knative-prow bot requested review from aliok and nrrso May 5, 2025 19:38
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 5, 2025
Copy link
Member

@aliok aliok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold

Hold for others.

Thanks Evan!

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 5, 2025
Copy link

knative-prow bot commented May 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [aliok,evankanderson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 5, 2025
@matzew
Copy link
Member

matzew commented May 6, 2025

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/documentation lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants