Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

07 api from new version of script #1571

Merged
merged 2 commits into from
Jul 9, 2019
Merged

07 api from new version of script #1571

merged 2 commits into from
Jul 9, 2019

Conversation

RichieEscarez
Copy link
Contributor

Updated version of 07 API using revised API build script (#1559)

@RichieEscarez RichieEscarez requested a review from ahmetb July 3, 2019 05:50
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 3, 2019
@knative-prow-robot knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved labels Jul 3, 2019
@ahmetb
Copy link
Contributor

ahmetb commented Jul 4, 2019

I don’t know if Netlify stages these somewhere, but the diff looks good I think.

@RichieEscarez
Copy link
Contributor Author

I don’t know if Netlify stages these somewhere, but the diff looks good I think.

No not yet. Netlify has that as a built feature if we use only a single repo (ie our knative/website repo auto builds previews) but since our docs repo is separate from our Netlify site code, I need to add some type of preview build page (which im slowly working on).

@samodell
Copy link
Contributor

samodell commented Jul 9, 2019

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RichieEscarez, samodell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [RichieEscarez,samodell]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahmetb
Copy link
Contributor

ahmetb commented Jul 9, 2019

Yaay!

@knative-prow-robot knative-prow-robot merged commit 71ff376 into knative:master Jul 9, 2019
@RichieEscarez RichieEscarez deleted the latestapiscript branch August 15, 2019 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmetb ahmetb ahmetb left review comments

@carieshmarie carieshmarie Awaiting requested review from carieshmarie

@gyliu513 gyliu513 Awaiting requested review from gyliu513

Assignees

@samodell samodell

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RichieEscarez @ahmetb @samodell @knative-prow-robot @googlebot