Skip to content

Comments

docs: add FUNC_USERNAME/PASSWORD env vars documentation#6543

Merged
knative-prow[bot] merged 1 commit intoknative:mainfrom
Kunal1522:knative-fast-b
Feb 11, 2026
Merged

docs: add FUNC_USERNAME/PASSWORD env vars documentation#6543
knative-prow[bot] merged 1 commit intoknative:mainfrom
Kunal1522:knative-fast-b

Conversation

@Kunal1522
Copy link
Contributor

@Kunal1522 Kunal1522 commented Dec 18, 2025

Fixes knative/func#3299

Proposed Changes

  • Added documentation for FUNC_USERNAME and FUNC_PASSWORD environment variables in docs/snippets/proc-building-function.md.
  • Added documentation for FUNC_USERNAME and FUNC_PASSWORD environment variables in docs/snippets/proc-deploying-function.md.
  • Clarified that these environment variables now work with all builders (host, s2i, and pack) for private registry authentication, following the refactoring in knative/func#3298.
  • Since these are snippets, the updates will automatically appear in the "Building functions", "Deploying functions", and "Getting started" documentation pages.

@netlify
Copy link

netlify bot commented Dec 18, 2025 •
edited
Loading

✅ Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a72a82f
🔍 Latest deploy log https://app.netlify.com/projects/knative/deploys/698960970e45350008321471
😎 Deploy Preview https://deploy-preview-6543--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 18, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Kunal1522 / name: Kunal Kashyap (a72a82f)

@knative-prow
Copy link

knative-prow bot commented Dec 18, 2025

Welcome @Kunal1522! It looks like this is your first PR to knative/docs 🎉

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 18, 2025
@Kunal1522 Kunal1522 mentioned this pull request Dec 18, 2025
Closed
@Cali0707
Copy link
Member

Cali0707 commented Dec 18, 2025

/cc @gauron99 @lkingland

@knative-prow knative-prow bot requested review from gauron99 and lkingland December 18, 2025 16:40
@gauron99
Copy link
Contributor

gauron99 commented Dec 19, 2025

Thanks for the ping. I commented on the mentioned issue here

@Kunal1522 Kunal1522 marked this pull request as draft December 26, 2025 19:36
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 26, 2025
@dprotaso
Copy link
Member

dprotaso commented Feb 5, 2026

@gauron99 is this docs change still relevant?

@gauron99
Copy link
Contributor

gauron99 commented Feb 6, 2026

i think the verify mkdocs strict check is unrelated
cc @dprotaso

@dprotaso
Copy link
Member

dprotaso commented Feb 6, 2026

@gauron99 it's unrelated - you can lgtm and approve when you're ready and it won't block the PR

@dprotaso
Copy link
Member

dprotaso commented Feb 6, 2026

The PR is still a draft

@Kunal1522
Copy link
Contributor Author

Kunal1522 commented Feb 6, 2026

my bad i missed to mark it for review

@Kunal1522 Kunal1522 marked this pull request as ready for review February 6, 2026 17:52
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 6, 2026
@knative-prow knative-prow bot requested a review from Leo6Leo February 6, 2026 17:52
@gauron99
Copy link
Contributor

gauron99 commented Feb 8, 2026

@Kunal1522 could we mention this for func run as well?

@Kunal1522
Copy link
Contributor Author

Kunal1522 commented Feb 9, 2026

done @gauron99 i think mkdocs error is unrelated to my changes

@gauron99
Copy link
Contributor

gauron99 commented Feb 10, 2026

cc @lkingland

@gauron99
Copy link
Contributor

gauron99 commented Feb 10, 2026 •
edited
Loading

/hold for luke/matej review

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 10, 2026
@gauron99
Copy link
Contributor

gauron99 commented Feb 10, 2026

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2026
@gauron99
Copy link
Contributor

gauron99 commented Feb 10, 2026

just to mention:
this PR implements this for all builders
this PR unhides the flags

@matejvasek
Copy link
Contributor

matejvasek commented Feb 11, 2026

/lgtm

@gauron99
Copy link
Contributor

gauron99 commented Feb 11, 2026

/approve

@gauron99
Copy link
Contributor

gauron99 commented Feb 11, 2026

@dprotaso could you approve please

@dprotaso
Copy link
Member

dprotaso commented Feb 11, 2026

FYI func leads should have access to approve so it shouldn't be blocked on me

docs/OWNERS

Line 12 in a587804

- functions-wg-leads

/hold cancel
/approve

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 11, 2026
@knative-prow
Copy link

knative-prow bot commented Feb 11, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, gauron99, Kunal1522

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2026
@knative-prow knative-prow bot merged commit 9699871 into knative:main Feb 11, 2026
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Cali0707 Cali0707 Awaiting requested review from Cali0707

@zainabhusain227 zainabhusain227 Awaiting requested review from zainabhusain227

@gauron99 gauron99 Awaiting requested review from gauron99

@lkingland lkingland Awaiting requested review from lkingland

@Leo6Leo Leo6Leo Awaiting requested review from Leo6Leo

Assignees

@matejvasek matejvasek

@gauron99 gauron99

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add release note and docs to credentials refactoring.

5 participants

@Kunal1522 @Cali0707 @gauron99 @dprotaso @matejvasek