[release-1.11] Adding the variable KNATIVE_EVENTING_RELEASE_TLS to install latest eventing TLS
#53
knative-prow-robotknative-style.yaml
on: pull_request
style
/
changes
7s
style
/
...
/
shell
13s
style
/
...
/
yaml
0s
style
/
...
/
github_actions
0s
style
/
...
/
Auto-format and Check
style
/
...
/
Do Not Submit
style
/
...
/
Lint
Matrix: style / Golang / Boilerplate Check
Waiting for pending jobs
Annotations
10 errors
|
style / suggester / shell:
library.sh#L166
[shellcheck (suggestion)] reported by reviewdog 🐶
Raw Output:
library.sh:166:- local upper="$(echo $1 | tr a-z A-Z)"
library.sh:166:+ local upper="$(echo "$1" | tr a-z A-Z)"
|
|
style / suggester / shell:
library.sh#L182
[shellcheck (suggestion)] reported by reviewdog 🐶
Raw Output:
library.sh:182:- [[ "$(type -t $1)" == "function" ]]
library.sh:182:+ [[ "$(type -t "$1")" == "function" ]]
|
|
style / suggester / shell:
library.sh#L230
[shellcheck (suggestion)] reported by reviewdog 🐶
Raw Output:
library.sh:230:- if ! kubectl ${KUBECTL_ARGS} > /dev/null 2>&1; then
library.sh:230:+ if ! kubectl "${KUBECTL_ARGS}" > /dev/null 2>&1; then
|
|
style / suggester / shell:
library.sh#L238
[shellcheck (suggestion)] reported by reviewdog 🐶
Raw Output:
library.sh:238:- kubectl ${KUBECTL_ARGS}
library.sh:238:+ kubectl "${KUBECTL_ARGS}"
|
|
style / suggester / shell:
library.sh#L256
[shellcheck (suggestion)] reported by reviewdog 🐶
Raw Output:
library.sh:256:- if kubectl ${KUBECTL_ARGS} > /dev/null 2>&1; then
library.sh:256:+ if kubectl "${KUBECTL_ARGS}" > /dev/null 2>&1; then
|
|
style / suggester / shell:
library.sh#L264
[shellcheck (suggestion)] reported by reviewdog 🐶
Raw Output:
library.sh:264:- kubectl ${KUBECTL_ARGS}
library.sh:264:+ kubectl "${KUBECTL_ARGS}"
|
|
style / suggester / shell:
library.sh#L279
[shellcheck (suggestion)] reported by reviewdog 🐶
Raw Output:
library.sh:279:- local pods="$(kubectl get pods --no-headers -n $1 | grep -v Terminating)"
library.sh:279:+ local pods="$(kubectl get pods --no-headers -n "$1" | grep -v Terminating)"
|
|
style / suggester / shell:
library.sh#L286
[shellcheck (suggestion)] reported by reviewdog 🐶
Raw Output:
library.sh:286:- local status=(`echo -n ${pod} | cut -f2 -d' ' | tr '/' ' '`)
library.sh:286:+ local status=($(echo -n "${pod}" | cut -f2 -d' ' | tr '/' ' '))
|
|
style / suggester / shell:
library.sh#L313
[shellcheck (suggestion)] reported by reviewdog 🐶
Raw Output:
library.sh:313:- kubectl -n $1 get pods "${failed_pod}" -oyaml
library.sh:313:+ kubectl -n "$1" get pods "${failed_pod}" -oyaml
|
|
style / suggester / shell
reviewdog: Too many results (annotations) in diff.
You may miss some annotations due to GitHub limitation for annotation created by logging command.
Please check GitHub Actions log console to see all results.
Limitation:
- 10 warning annotations and 10 error annotations per step
- 50 annotations per job (sum of annotations from all the steps)
- 50 annotations per run (separate from the job annotations, these annotations aren't created by users)
Source: https://github.community/t5/GitHub-Actions/Maximum-number-of-annotations-that-can-be-created-using-GitHub/m-p/39085
|