autoscaler: ignore ScaleDownDelay if not reachable

[scottjmaddox]

Proposed Changes

• autoscaler: ignore ScaleDownDelay if not reachable
  • addresses an issue we noticed where old revisions would hang around for the full scale down delay even if zero traffic is being directed to them, resulting in unnecessary resource utilization (especially if the scale down delay is large)

Release Note

autoscaling: ignore ScaleDownDelay if the revision is not reachable

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: scottjmaddox / name: Scott J Maddox (e2d98b1)
• ✅ login: dprotaso / name: Dave Protasowski (ec2d263)

[knative-prow]

Hi @scottjmaddox. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[dprotaso]

/ok-to-test

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.04%. Comparing base (3c3e59c) to head (ec2d263).
Report is 9 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #15831   +/-   ##
=======================================
  Coverage   75.04%   75.04%           
=======================================
  Files         222      222           
  Lines       18074    18074           
=======================================
  Hits        13563    13563           
+ Misses       4160     4159    -1     
- Partials      351      352    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[scottjmaddox]

@dprotaso Any action needed from me on this? Thanks.

[skonto]

Hi there are some code style issues.

[dprotaso]

/override "codecov/project"

tracking that as a separate issue - knative/infra#634

Ran gofumpt on the file - thanks @scottjmaddox

/lgtm
/approve

[knative-prow]

@dprotaso: Overrode contexts on behalf of dprotaso: codecov/project

In response to this:

/override "codecov/project"

tracking that as a separate issue - knative/infra#634

Ran gofumpt on the file - thanks @scottjmaddox

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, scottjmaddox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dprotaso]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jyono]

🎉