Skip to content

Commit

Permalink
fix: list component fixed
Browse files Browse the repository at this point in the history
  • Loading branch information
knownotunknown committed Mar 14, 2024
1 parent a409090 commit e60400d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
6 changes: 1 addition & 5 deletions src/views/components/common/List/List.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -74,14 +74,10 @@ function List<T>(props: ListProps<T>): JSX.Element {
const transformFunction = props.children;

useEffect(() => {
// check if the draggables content has *actually* changed
if (props.draggables.every((element, index) => equalityCheck(element, items[index].content))) {
if (props.draggables.length === items.length && props.draggables.every((element, index) => equalityCheck(element, items[index].content))) {
console.log("List's draggables have not changed");
return;
}

console.log("List's draggables have changed, updating...");

setItems(wrap(props.draggables));
}, [props.draggables]);

Expand Down
4 changes: 2 additions & 2 deletions src/views/hooks/useSchedules.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ async function fetchData() {
UserScheduleStore.get('schedules'),
UserScheduleStore.get('activeIndex'),
]);
schedulesCache = storedSchedules.map(s => new UserSchedule(s));
schedulesCache = storedSchedules.map(s => new UserSchedule({...s, updatedAt: s.updatedAt || Date.now()}));
activeIndexCache = storedActiveIndex >= 0 ? storedActiveIndex : 0;
}

Expand Down Expand Up @@ -64,7 +64,7 @@ export default function useSchedules(): [active: UserSchedule, schedules: UserSc

export function getActiveSchedule(): UserSchedule {
return (
schedulesCache[activeIndexCache] || new UserSchedule({ courses: [], name: 'An error has occurred', hours: 0 })
schedulesCache[activeIndexCache] || new UserSchedule({ courses: [], name: 'An error has occurred', hours: 0, updatedAt: Date.now() })
);
}

Expand Down

0 comments on commit e60400d

Please sign in to comment.