Fix issue with model relations being lost after refresh in getExample… #901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ModelFromFactoryCreate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description :
This PR addresses an issue in the getExampleModelFromFactoryCreate function, where model relations were being loaded before calling refresh(). This caused the loaded relations to be cleared when the model was refreshed, resulting in the loss of relation data.
Example :
In a case like this:
#[ResponseFromApiResource(UserResponse::class, User::class, with: ['job.agency'])]The agency relation would be cleared by the refresh(), even though it is part of the relations to be loaded. The loading works, but the refresh wipes out the agency relation. With this fix, this issue is resolved.
Changes :
Moved the refresh() call to occur before load() in getExampleModelFromFactoryCreate, ensuring that relations are loaded after the model has been refreshed, preserving the relation data.
This fix will prevent relations from being lost after a model refresh and ensure proper loading of related models.
Let me know if you need further adjustments !