Skip to content

Fix issue with route scope binding when getRouteKeyName method is different from Route scoped #972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: v5
Choose a base branch
from
Open

Fix issue with route scope binding when getRouteKeyName method is different from Route scoped #972

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b288008
Fix issue with route scope binding
Joemires Mar 21, 2025
7bbd233
Merge branch 'v5' into v5
shalvah Apr 17, 2025
22efb07
Merge branch 'v5' into v5
Joemires Aug 31, 2025
2ec7b1b
Merge branch 'v5' into v5
shalvah Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/Extracting/Strategies/UrlParameters/GetFromLaravelAPI.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ protected function inferBetterTypesAndExamplesForEloquentUrlParameters(array $pa
// If User model has `id` as an integer, then {id} param should be an integer
$typeHintedEloquentModels = UrlParamsNormalizer::getTypeHintedEloquentModels($endpointData->method);
foreach ($typeHintedEloquentModels as $argumentName => $modelInstance) {
$routeKey = $modelInstance->getRouteKeyName();
$routeKey = $endpointData->route->bindingFields()[$argumentName] ?? $modelInstance->getRouteKeyName();

// Find the param name. In our normalized URL, argument $user might be param {user}, or {user_id}, or {id},
if (isset($parameters[$argumentName])) {
Expand Down Expand Up @@ -116,9 +116,8 @@ protected function inferBetterTypesAndExamplesForEloquentUrlParameters(array $pa
// Now infer.
foreach ($modelInstances as $paramName => $modelInstance) {
// If the routeKey is the same as the primary key in the database, use the PK's type.
$routeKey = $modelInstance->getRouteKeyName();
$type = $modelInstance->getKeyName() === $routeKey
? static::normalizeTypeName($modelInstance->getKeyType()) : 'string';
$routeKey = in_array($paramName, $endpointData->route->bindingFields()) ? $paramName : $modelInstance->getRouteKeyName();;
$type = $modelInstance->getKeyName() === $routeKey ? static::normalizeTypeName($modelInstance->getKeyType()) : 'string';

$parameters[$paramName]['type'] = $type;

Expand Down