support building from a scratch image #1350
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpanato
reviewed
Jul 1, 2024
cpanato
reviewed
Jul 1, 2024
|
@cpanato updated |
|
Great! I hope this can be merged soon. |
|
This Pull Request is stale because it has been open for 90 days with |
|
@cpanato Any feedback from reviewing? |
imjasonh
approved these changes
Feb 11, 2025
| if err != nil { | ||
| t.Fatalf("expected no error when getting image for digest %s, got %s", m.Digest, err) | ||
| } | ||
| ls, err := img.Layers() |
There was a problem hiding this comment.
It looks like this err is unchecked.
| t.Errorf("unexpected OS %s", m.Platform.OS) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Suggested change
(to appease the linter)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #207; Add e2e testing based on #1038.
The Windows Delve debugger is also failing on the main branch, so I've left it as is for now.