Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add esm entrypoint #12

Closed
wants to merge 9 commits into from
Closed

Conversation

Souler
Copy link
Contributor

@Souler Souler commented Oct 4, 2024

No description provided.

@3imed-jaberi 3imed-jaberi self-requested a review October 11, 2024 12:43
@3imed-jaberi
Copy link
Member

@Souler Thanks for your contribution here, I will take care of this part due to publish the release quicker.

@Souler
Copy link
Contributor Author

Souler commented Oct 12, 2024

@3imed-jaberi

Yea, this is what happens when you force push into a public branch.

To be honest, I'm surprised and disapponted by your work ethic. You have effectevily removed my contributions from the history of this repo.

I'm not even going to comment on the fact that you made me remove the package lock file just to add it yourself right afterwards (because it was the correct thing to do).

@3imed-jaberi
Copy link
Member

@Souler I don't remove your work, I just squash your commits as you can see here.

As I told you in my previous comment, we don't push the lock file but due to the usage of GH Action with the current configuration we need the lock file. So, I take the road to fix it immediately here. Then some tests failed (fix) ...

@Souler
Copy link
Contributor Author

Souler commented Oct 12, 2024

@3imed-jaberi

  1. You force-pushed to a public repo; rewriting the history of commits after merging. That IS removing (and altering) my work for no good reason. If you consider yourself an OSS maintainer you should know that force pushing is heavily discouraged because you negatively affect downstream forks. However, I'm happy you are still top contributor to the repo (I cant really imagine any other reason why you would do that).
  2. Regarding the package-lock.json; it's almost like you could have re-considered before merging after being linked official documentation on the matter or even deciding to mirror the behavior of the "root" package of this org (i.e: koa). Including lockfiles in version control is an industry standard. Not doing it is negligent on several aspects: security and developer experience.
  3. Because you saw red on the CI, you panicked decided to fix a failing test in a way that will cause it to fail on any developer machine that is not configured as UTC. I was about to open a PR to address it after seeing the failure; but I'll leave you to it.

I was super motivated to keep contributing to this repo or the org overall; but seeing this treatment I'm 100% not going to do so. I really hope you eventually understand why what you did is just plain wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants