-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ioredis v5 and dependency updates #86
base: master
Are you sure you want to change the base?
Conversation
package.json
Outdated
}, | ||
"engines": { | ||
"node": ">= 4" | ||
"node": ">= 14" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bumping node min version to 14 is not necessary, ioredis v5 states that it is still compatible with node v12.
https://github.com/luin/ioredis/wiki/Upgrading-from-v4-to-v5
and in its package.json it is set to >= 12.22.0
https://github.com/luin/ioredis/blob/92aefaac13f42ad14986fde47c640ff8edc415ef/package.json#L92
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback @falkenhawk. I updated the version to match ioredis.
…configurable, and move ioredis to peer dependency
This PR:
REDIS_URL
env variable to allow the redis test server to be configurable on local envsyarn.lock
file.Checklist