Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ioredis v5 and dependency updates #86

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vsumner
Copy link

@vsumner vsumner commented Dec 1, 2022

This PR:

  • Updates ioredis to v5
  • Updates min node version to v14 to match ioredis
  • Moves ioredis to a peer dependency
  • Adds REDIS_URL env variable to allow the redis test server to be configurable on local envs
  • Updates dependencies to minor/patch versions in the yarn.lock file.

Checklist

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

package.json Outdated
},
"engines": {
"node": ">= 4"
"node": ">= 14"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bumping node min version to 14 is not necessary, ioredis v5 states that it is still compatible with node v12.
https://github.com/luin/ioredis/wiki/Upgrading-from-v4-to-v5

and in its package.json it is set to >= 12.22.0
https://github.com/luin/ioredis/blob/92aefaac13f42ad14986fde47c640ff8edc415ef/package.json#L92

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback @falkenhawk. I updated the version to match ioredis.

@socket-security
Copy link

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

⬆️ Updated Package Version Diff Added Capability Access +/- Transitive Count Publisher
[email protected] 11.0.0...11.1.0 None +53/-42 mysticatea
@commitlint/[email protected] 8.3.5...8.3.6 None +69/-41 escapedcat
[email protected] 2.11.0...2.13.4 None +16/-15 dead_horse
[email protected] 1.0.3...1.0.6 None +0/-0 niftylettuce
[email protected] 4.1.1...4.3.4 None +0/-0 qix
@babel/[email protected] 7.8.3...7.20.5 filesystem, shell, environment +38/-18 nicolo-ribaudo
[email protected] 3.1.0...3.1.2 None +57/-50 dead_horse
[email protected] 4.14.1...5.3.2 None +5/-6 ioredis-robot
[email protected] 3.0.0...3.0.2 None +3/-3 isaacs
@babel/[email protected] 7.8.3...7.19.6 filesystem, shell +49/-21 nicolo-ribaudo
[email protected] 2.0.4...2.3.0 None +0/-0 niftylettuce
@babel/[email protected] 7.8.3...7.20.2 filesystem, shell +129/-93 nicolo-ribaudo
@commitlint/[email protected] 8.3.4...8.3.6 None +2/-2 escapedcat
@babel/[email protected] 7.8.3...7.20.6 None +1/-1 nicolo-ribaudo
[email protected] 4.0.3...4.0.4 None +0/-0 wavded
@babel/[email protected] 7.8.3...7.19.3 eval +51/-40 nicolo-ribaudo
[email protected] 0.25.3...0.25.4 None +135/-107 sindresorhus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants