Skip to content
This repository has been archived by the owner on Aug 31, 2024. It is now read-only.

ack FIX added to arguments and context #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zhakhalov
Copy link

Please merge this pull request for fixing unability to use acknolagements.
Example usage

this.ack(someData);

or

function *(next, ack) {
  ack(someData);
}

@ariporad
Copy link
Contributor

Hi!

Just to be clear, this allows both this.ack() and accepting an ack function? I think we should just do one, (personally, I'd prefer a this.ack, or better yet, this.body setter), but I could be convinced otherwise.

Also, could you please make sure your branch is up to date with master, passes the tests, and add tests for anything you've added? Thanks!

@ariporad ariporad added this to the 0.1.0 milestone Oct 25, 2015
@tunnckoCore
Copy link

@zhakhalov any response?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants