Extend format option to support redirection of trailing slash for directories#136
Open
johnnyxwan wants to merge 5 commits intokoajs:masterfrom
Open
Extend format option to support redirection of trailing slash for directories#136johnnyxwan wants to merge 5 commits intokoajs:masterfrom
format option to support redirection of trailing slash for directories#136johnnyxwan wants to merge 5 commits intokoajs:masterfrom
Conversation
johnnyxwan
changed the title
format option support redirection of trailing slash for directoriesformat option to support redirection of trailing slash for directories
Member
3imed-jaberi
left a comment
3imed-jaberi
left a comment
There was a problem hiding this comment.
@johnnyxwan thank you for you're PR. can you write the test for these update!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extended
formatoption from( *true | false )to( *'follow' | 'redirect' | false ).'follow'behaves the same as the oldtrue, and keep as default.'redirect'is used for the redirection new feature.If trailing slash for directories is absent and index is defined, when
formatis set to'redirect', it redirects the page using HTTP 302 to the URL with trailing slash added, at the same time respecting previous scheme and query.Return value of
await send()istruewhen such a redirection happened, in contrast ofundefinedwhen encountering errors andpathnamewhen the file is served.