Delete cookie on session destruction #143
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now when the session is destroyed, the session cookie is made empty, not removed. That's an incorrect behavior, the cookie should be deleted as well. For that, we need to set the expiration date to the past, not just an empty value.
|
looks like browser will delete the cookie when received empty string as a cookie value ( works with chrome and safari) |
|
For me it affected autotests that failed when I switched from another session module. |
dead-horse
reviewed
Oct 23, 2018
| @@ -272,7 +272,7 @@ class ContextSession { | |||
| const externalKey = this.externalKey; | |||
|
|
|||
| if (externalKey) await this.store.destroy(externalKey); | |||
| ctx.cookies.set(key, '', opts); | |||
There was a problem hiding this comment.
we should keep other options so we will delete ${key}.sig also.
|
@dead-horse Any updates on when this fix will be merged? |
|
@ejose19 @dead-horse I've created a pull request with code to expire the .sig and session cookies #180 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now when the session is destroyed, the session cookie is made empty, not removed.
That's an incorrect behavior, the cookie should be deleted as well. For that, we need to set the expiration date to the past, not just an empty value.