Skip to content

Support setting cookie domain on a per-request basis. #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Support setting cookie domain on a per-request basis. #227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44505f9
Support setting cookie domain on a per-request basis.
rahulgi Apr 23, 2024
7a10a72
Use single quotes.
rahulgi Apr 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/context.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ class ContextSession {
debug('decode %j error: %s', cookie, err);
if (!(err instanceof SyntaxError)) {
// clean this cookie to ensure next request won't throw again
ctx.cookies.set(opts.key, '', opts);
ctx.cookies.set(opts.key, '', util.modifyOptsForRequest(ctx, opts));
// ctx.onerror will unset all headers, and set those specified in err
err.headers = {
'set-cookie': ctx.response.get('set-cookie'),
Expand Down Expand Up @@ -287,7 +287,7 @@ class ContextSession {
const externalKey = this.externalKey;

if (externalKey) await this.store.destroy(externalKey, { ctx });
ctx.cookies.set(key, '', opts);
ctx.cookies.set(key, '', util.modifyOptsForRequest(ctx, opts));
}

/**
Expand Down Expand Up @@ -328,7 +328,7 @@ class ContextSession {
if (opts.externalKey) {
opts.externalKey.set(this.ctx, externalKey);
} else {
this.ctx.cookies.set(key, externalKey, opts);
this.ctx.cookies.set(key, externalKey, util.modifyOptsForRequest(this.ctx, opts));
}
return;
}
Expand All @@ -338,7 +338,7 @@ class ContextSession {
json = opts.encode(json);
debug('save %s', json);

this.ctx.cookies.set(key, json, opts);
this.ctx.cookies.set(key, json, util.modifyOptsForRequest(this.ctx, opts));
}
}

Expand Down
8 changes: 8 additions & 0 deletions lib/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,5 +35,13 @@ module.exports = {
return crc(JSON.stringify(sess));
},

modifyOptsForRequest(ctx, opts) {
const optsCopy = Object.assign({}, opts);
if (typeof opts.domain === 'function') {
optsCopy.domain = opts.domain(ctx, opts);
}
return optsCopy;
},

CookieDateEpoch: 'Thu, 01 Jan 1970 00:00:00 GMT',
};