Skip to content

Comments

AI: Allow a function to be referenced in PS4#3386

Closed
dotysan wants to merge 1 commit intokoalaman:masterfrom
dotysan:fix_fp_sc2329
Closed

AI: Allow a function to be referenced in PS4#3386
dotysan wants to merge 1 commit intokoalaman:masterfrom
dotysan:fix_fp_sc2329

Conversation

@dotysan
Copy link
Contributor

@dotysan dotysan commented Jan 3, 2026

Closes #3385.

Review required.

@dotysan dotysan marked this pull request as ready for review January 3, 2026 22:32
@koalaman
Copy link
Owner

koalaman commented Feb 1, 2026

This code is uncomfortably tightly coupled to the specific case of assigning a single quoted string regex matching `f` or $(f) to PS4. It does fix the specific case in the bug, but would fail for even minor variations like PS4="\$(PS4func)" or PS4='$(date | PS4func)', so it makes it harder to predict behavior.

Unfortunately there isn't really a great approach to handle cases like this at this time. In this case it would be better to suppress with a comment.

@koalaman koalaman closed this Feb 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

false postive SC2329

2 participants