-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new search component - implement Combobox approach #506
Conversation
✅ Deploy Preview for kobalte ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SolutionCancel timeouts when onChange is triggered. (May introduce flickering momentarily to loading icon?) ProblemExample search: Screen.Recording.2024-10-29.at.8.38.00.am.mp4Note: debouncer is triggered as emoji is selected (indicated by spinner), this should not happen. |
Typing fast then stopping somehow does not display suggestion options: Screen.Recording.2024-10-29.at.9.07.16.am.mp4Issue seems to occur when:
|
5141e63
to
e3646e8
Compare
The dropdown bug - solutionFound the cause of the bug:
The possible fix:
|
013b2b7
to
898973d
Compare
@jer3m01 I think this component is ready for review |
406b47f
to
aaafbfd
Compare
Fixed some dark mode styling issues: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the work! Looks great!
Could you open separate issues for the bugs that are still present?
Will merge soon.
…ers before onChange
4771fa5
to
4943738
Compare
Addresses:
closes #504
closes #224 - command palette can also be implemented with combobox
closes #262 - filter would be managed externally instead of internally
closes #261
Draft
Search
component implementation using Combobox underneathThis solution should be more maintainable than #501
Component
Combobox
components asSearch
SearchRoot
to implementComboBoxBase
disabling defaultFilter as this is handled externally - eg: databaseTest
No results - cannot open dropdown with solid testing libraryDoc
Bugs:
options
-> typing -> non-emptyoptions
-> results in no dropdown unless dropdown is already open (Nani? ¯_(ツ)_/¯)noResetInputOnBlur
option to ComboboxOld dropdown options shown on blur - this is a combobox behaviour. WHY?Note: I'm using
minisearch
npm package to perform text searchFor the most part, this component is considered complete