feat: new search component - implement Combobox approach#506
feat: new search component - implement Combobox approach#506jer3m01 merged 27 commits intokobaltedev:mainfrom
Conversation
✅ Deploy Preview for kobalte ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SolutionCancel timeouts when onChange is triggered. (May introduce flickering momentarily to loading icon?) ProblemExample search: Screen.Recording.2024-10-29.at.8.38.00.am.mp4Note: debouncer is triggered as emoji is selected (indicated by spinner), this should not happen. |
|
Typing fast then stopping somehow does not display suggestion options: Screen.Recording.2024-10-29.at.9.07.16.am.mp4Issue seems to occur when:
|
5141e63 to
e3646e8
Compare
The dropdown bug - solutionFound the cause of the bug:
The possible fix:
|
013b2b7 to
898973d
Compare
|
@jer3m01 I think this component is ready for review |
406b47f to
aaafbfd
Compare
|
Fixed some dark mode styling issues: |
jer3m01
left a comment
There was a problem hiding this comment.
Thanks for all the work! Looks great!
Could you open separate issues for the bugs that are still present?
Will merge soon.
…ers before onChange
4771fa5 to
4943738
Compare

Addresses:
closes #504
closes #224 - command palette can also be implemented with combobox
closes #262 - filter would be managed externally instead of internally
closes #261
Draft
Searchcomponent implementation using Combobox underneathThis solution should be more maintainable than #501
Component
Comboboxcomponents asSearchSearchRootto implementComboBoxBasedisabling defaultFilter as this is handled externally - eg: databaseTest
No results - cannot open dropdown with solid testing libraryDoc
Bugs:
options-> typing -> non-emptyoptions-> results in no dropdown unless dropdown is already open (Nani? ¯_(ツ)_/¯)noResetInputOnBluroption to ComboboxOld dropdown options shown on blur - this is a combobox behaviour. WHY?Note: I'm using
minisearchnpm package to perform text searchFor the most part, this component is considered complete