feat: edit collection permission

[Jarsen136]

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

• Feature

Needs QA check

• @kodadot/qa-guild please review

Context

• Closes Collection Edit: Support Permissions Update #11148

Screenshot 📸

• My fix has changed something on UI; a screenshot is best to understand changes for others.

ref: https://wiki.polkadot.network/docs/learn-nft-pallets

[netlify]

✅ Deploy Preview for koda-canary ready!

Name	Link
🔨 Latest commit	3b0a555
🔍 Latest deploy log	https://app.netlify.com/sites/koda-canary/deploys/6780fcbe404ab40008d1bc5f
😎 Deploy Preview	https://deploy-preview-11217--koda-canary.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[vikiival]

Please use normal price input

[Jarsen136]

Please use normal price input

✅ Updated

[preschian]

nice, lgtm

[vikiival]

~ incorrect impl

1. It does not make sense to have issuer & price :) (will you pay for yourself?)

2. Setting public & set price > 0 means that you wont be able to mint on koda
   2.1 Warning that setting public will allow anyone to mint into your collection

3. Holder of is missing search input where user can select which collection is eligible.
   3.1 Warning that by setting type to holder of user wont be able to mint on koda

[Jarsen136]

~ incorrect impl

1. It does not make sense to have issuer & price :) (will you pay for yourself?)
2. Setting public & set price > 0 means that you wont be able to mint on koda
   2.1 Warning that setting public will allow anyone to mint into your collection
3. Holder of is missing search input where user can select which address is eligible.
   3.1 Warning that by setting type to holder of user wont be able to mint on koda

Thanks for providing more details.

A question about the holderOf type. You're talking about the address search input. Shouldn't it be an input of collection id? With this collection id, we could know if the user is the holder of collection A and is eligible to mint nft on collection B.

[vikiival]

A question about the holderOf type. You're talking about the address search input. Shouldn't it be an input of collection id?

Yes, you are completely right, I apologize for my mistake. (I have edited the comment)

I meant

 search input where user can select which collection is eligible

Why search input?

Well if you take it from perspective of artist / @JustLuuuu they have no idea what collection Id is. (example https://koda.art/ahp/collection/258)
They do not know that this collection has id 258, but they do know that collection is called ANOMALY ^-^

[JustLuuuu]

I know what a collection ID is! But its true that artists don't know it 😂

[Jarsen136]

~ incorrect impl

1. It does not make sense to have issuer & price :) (will you pay for yourself?)
2. Setting public & set price > 0 means that you wont be able to mint on koda
   2.1 Warning that setting public will allow anyone to mint into your collection
3. Holder of is missing search input where user can select which collection is eligible.
   3.1 Warning that by setting type to holder of user wont be able to mint on koda

Updated

[hassnian]

no price has been set but i can still submit, if the switch is not meant to be clickable we should hide it

after pressing save changes

[vikiival]

#11217 (review)

2. Setting public & set price > 0 means that you wont be able to mint on koda

I will try to rephrase as it is incorrectly implemented.

• If you set price for public minting, you will not be able to mint in Koda.
• Moreover anyone can mint into your collection

[Jarsen136]

no price has been set but i can still submit, if the switch is not meant to be clickable we should hide it

It's meant to disable the switch when public is selected. I have hidden the switch now

after pressing save changes

In this case, I would disable the button.

[Jarsen136]

#11217 (review)

2. Setting public & set price > 0 means that you wont be able to mint on koda

I will try to rephrase as it is incorrectly implemented.

• If you set price for public minting, you will not be able to mint in Koda.
• Moreover anyone can mint into your collection

I'm not sure if I understand correctly. For the public type, should it allow the user to set zero price, or not?

Here is the current warning message implemented. Feel free to let me know how it is supposed to be. @vikiival

[Jarsen136]

@vikiival Could you please take a look?

[vikiival]

@vikiival Could you please take a look?

Yup
Can also @kodadot/internal-dev add review pls?

[hassnian]

1. holderOf - visual change

move the cross to the end of the container

3. I can save changes even though no changes have been made with the selected mintType

I think changing mintType should clear the state of that mintType

CleanShot.2024-12-31.at.08.10.27.mp4

3. holderOf , shouldn't the switch be reversed ?

active when price can be set
and off when not ?

4. public, error when saving changes

CleanShot.2024-12-31.at.08.20.05.mp4

5. holderOf

Ideally a loading state when searching would be nice

CleanShot.2024-12-31.at.08.22.54.mp4

[netlify]

✅ Deploy Preview for polkadot ready!

Name	Link
🔨 Latest commit	9de8a8d
🔍 Latest deploy log	https://app.netlify.com/sites/polkadot/deploys/6775534047b1ad0009c8945f
😎 Deploy Preview	https://deploy-preview-11217--polkadot.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 16 Accessibility: 83 Best Practices: 83 SEO: 81 PWA: - View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[Jarsen136]

1. holderOf - visual change

move the cross to the end of the container

3. I can save changes even though no changes have been made with the selected mintType

I think changing mintType should clear the state of that mintType

CleanShot.2024-12-31.at.08.10.27.mp4
3. holderOf , shouldn't the switch be reversed ?

active when price can be set and off when not ?

4. public, error when saving changes

CleanShot.2024-12-31.at.08.20.05.mp4
5. holderOf

Ideally a loading state when searching would be nice

CleanShot.2024-12-31.at.08.22.54.mp4

Thanks for all the review comments! I have updated them and implemented them all. @hassnian

[exezbcz]

hey there, looking good, I would only change the logic of the input a bit

default is toggle off

Or do we want people to fill out specific price? Then it would make more sense to toggle it on by default.

[Jarsen136]

hey there, looking good, I would only change the logic of the input a bit

default is toggle off

Or do we want people to fill out specific price? Then it would make more sense to toggle it on by default.

It depends on which type the collection is.

There are three types of collection

1. public -> It has to set the price

2. issuer -> It can't set the price

3. holderOf -> It could have a price or not. In this case, it defaults off unless a price is already set on chain.

[exezbcz]

@Jarsen136 this looks good, seems like i have seen older version or it was the holder of version that did not look right with the double negative, hassnians comment described it #11217 (review)

thank you for this overview

only change is the copy then:
specify the price of the items -> Set specific price

as its a bit cleaner

[Jarsen136]

@Jarsen136 this looks good, seems like i have seen older version or it was the holder of version that did not look right with the double negative, hassnians comment described it #11217 (review)

thank you for this overview

only change is the copy then: specify the price of the items -> Set specific price

as its a bit cleaner

Thanks! The copy has been updated

[hassnian]

Nice! , small stuff

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud