Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adam-mini #1468

Open
wants to merge 23 commits into
base: sd3
Choose a base branch
from
Open

Adam-mini #1468

wants to merge 23 commits into from

Conversation

sdbds
Copy link
Contributor

@sdbds sdbds commented Aug 17, 2024

Tested batch size 1 can use about 16GB of VRAM.

@kohya-ss
Copy link
Owner

Thank you, that looks good!

Is the Adam_mini code from some repository? If so, please let me know so I can add the reference source and the license.

@sdbds
Copy link
Contributor Author

sdbds commented Aug 18, 2024

Thank you, that looks good!

Is the Adam_mini code from some repository? If so, please let me know so I can add the reference source and the license.

code from here and i think we should test for different blocks.
Officail says reduce 50% VRAM but i just found reduce 20%...
I changed block checked for lora part.
https://github.com/zyushun/Adam-mini

@FurkanGozukara
Copy link

Thank you, that looks good!
Is the Adam_mini code from some repository? If so, please let me know so I can add the reference source and the license.

code from here and i think we should test for different blocks. Officail says reduce 50% VRAM but i just found reduce 20%... I changed block checked for lora part. https://github.com/zyushun/Adam-mini

this sounds amazing half VRAM of Adam for same performance

ah only 20% vram usage :/ did you got good results with it? par with Adam for real?

@sdbds
Copy link
Contributor Author

sdbds commented Aug 18, 2024

Thank you, that looks good!
Is the Adam_mini code from some repository? If so, please let me know so I can add the reference source and the license.

code from here and i think we should test for different blocks. Officail says reduce 50% VRAM but i just found reduce 20%... I changed block checked for lora part. https://github.com/zyushun/Adam-mini

this sounds amazing half VRAM of Adam for same performance

ah only 20% vram usage :/ did you got good results with it? par with Adam for real?

At least on the SDXL I tested it works about the same.

@FurkanGozukara
Copy link

@sdbds thanks a lot for answer

do you think adafactor or mini adam would save more vram have you compared?

@Bocchi-Chan2023
Copy link

I'm curious about the difference in performance between CAME and adam-mini
#1409

@kohya-ss
Copy link
Owner

Is this PR includes #1417, or is it better to merge #1417 first?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants