Compute aspect ratios in log-space #1741
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
67372a
added a commit
to 67372a/sd-scripts
that referenced
this pull request
Nov 16, 2024
[2] aspect ratios compared in log-space have the desirable property that a 1:1 aspect ratio can be equidistant from buckets 2:1 and 1:2, each of which fit an equal proportion of its area. - https://arxiv.org/abs/2409.15997
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates aspect ratio bucketing to align with NovelAI's implementation. See their GitHub repo and paper (specifically footnote [2]) for reference.
https://github.com/NovelAI/novelai-aspect-ratio-bucketing/commits/main/?since=2024-09-25&until=2024-09-25
https://arxiv.org/abs/2409.15997