fix: metadata dataset degradation and make it work#2186
Merged
Conversation
… with batch support and output options
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes metadata dataset degradation issues and enhances the WD14 tagger functionality to support both JSON and JSONL metadata formats. The changes improve the handling of image metadata, add support for new tag categories, and provide better image preprocessing.
- Fix null comparison issues in metadata handling to prevent dataset degradation
- Add comprehensive JSONL metadata format support alongside existing JSON format
- Extend WD14 tagger with new tag categories (copyright, meta, model, quality) and improved model support
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| library/train_util.py | Fixes null checks in metadata comparison and refactors dataset initialization to better handle image paths and cache files |
| finetune/tag_images_by_wd14_tagger.py | Major enhancement adding JSONL support, new tag categories, improved image preprocessing, and better model handling |
| docs/wd14_tagger_README-ja.md | Updates Japanese documentation with current dependency versions and help command reference |
| docs/wd14_tagger_README-en.md | Updates English documentation with current dependency versions and help command reference |
Comments suppressed due to low confidence (1)
finetune/tag_images_by_wd14_tagger.py:1
- JSOL should be JSONL (JSON Lines format).
import argparse
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
…and ensure tags are returned
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documentation also needs to be updated.