Fix the 'off by 1' problem in dynamically resized LoRA rank #2194
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I understand correctly, the index returned by
index_sv_cumulative
andindex_sv_fro
is larger by 1 than it should be. For example,torch.searchsorted
works like this:If the user wants to keep 94% or 95% of
S
, thenindex
should be 1 (andnew_rank
in the functionrank_resize
should be 2).This problem is particularly visible when the new LoRA is rank 1. In the example above, if the user wants to keep 80% or 90% of
S
, thenindex
should be 0. I've seen many LoRAs of Flux/Wan/Qwen-Image on the internet that are almost rank 1.