Updates to README.md and Build.md #287
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Perfetto remove redundant std::move * Drop const instead
vlkale
reviewed
Jun 25, 2025
| 4. Type `make` | ||
|
|
||
| 5. Specify the generated .dylib file in the environment variable KOKKOS_TOOLS_LIBRARY when running your Kokkos-based application. | ||
| 2. Type `cmake .. -DCMAKE_INSTALL_PREFIX=${YOUR_KOKKOS_TOOLS_INSTALL_DIR}` and change any options, including tools you want turned on (some are by default off). (Optional) |
dalg24
reviewed
Jun 25, 2025
Build.md
Outdated
| 3. This generates the shared library within that subdirectory. | ||
|
|
||
|
|
||
| ### Run |
Member
There was a problem hiding this comment.
Run instructions do not belong to that file
Build.md
Outdated
|
|
||
| 3. Type `make` | ||
|
|
||
| # With Makefile (recommended) |
Member
There was a problem hiding this comment.
This needs to be updated (not as part of this PR)
We do not recommend using makefiles, we will eventually get rid of them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs for building are currently in two places, I have merged them into one file and attempted to make it read better